[tenant-namespace-operator] Fixed Ansible issues with unsafe yaml #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plnordquist
commented
Nov 7, 2023
plnordquist
commented
- Loaded the CR data using k8s_info so it is loaded unsafe
- Switched variable references to new CR var
- Updated variable references for Ansible best practices (snake case)
- Prepended underscore to variables to avoid clashes with operator snake case variables
Loaded the CR data using k8s_info so it is loaded unsafe Switched variable references to new CR var Updated variable references for Ansible best practices (snake case) Prepended underscore to variables to avoid clashes with operator snake case variables
kfox1111
reviewed
Nov 9, 2023
kfox1111
left a comment
kfox1111
left a comment
There was a problem hiding this comment.
Looks very good. Thanks!
A couple small questions inline.
containers/tenant-namespace-operator/roles/tenantnamespace/tasks/main.yml
Show resolved
Hide resolved
containers/tenant-namespace-operator/roles/tenantnamespace/tasks/main.yml
Show resolved
Hide resolved
Author
|
Tested again the behavior of the when blocks and I didn't see any issues. When metallb is not deployed it does not fail the playbook because of the missing IP. Also, I tested the behavior of setting a specific loadBalancerIP and that still works the same way as before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.