fix(combo): adiciona tratamento para retorno de erro HTTP na pesquisa

Ao ocorrer um erro na pequisa, utilizando serviço,
o componente ficava no estado de carregando e apresentava notificações de erro.

Fixes DTHFUI-3653

Author: jhonyeduardo

projects/ui/src/lib/components/po-field/po-combo/po-combo-filter.service.spec.ts

@@ -97,6 +97,24 @@ describe('PoComboFilterService ', () => {
   });
 
   describe('Methods:', () => {
+    it('getFilteredData: should contains X-PO-NO-MESSAGE in headers request', done => {
+      const urlWithParams = 'http://mockurl.com?filter=test';
+      const parsedParams: Array<PoComboOption> = [{ label: 'value1', value: 'value1' }];
+
+      spyOn(comboService, <any>'parseToArrayComboOption').and.returnValue(parsedParams);
+      spyOnProperty(comboService, 'url', 'get').and.returnValue('http://mockurl.com');
+
+      comboService.getFilteredData({ value: 'test' }).subscribe(response => {
+        expect(response).toEqual(parsedParams);
+        done();
+      });
+
+      const req = httpMock.expectOne((request: HttpRequest<any>) => request.urlWithParams === urlWithParams);
+      expect(req.request.headers.get('X-PO-No-Message')).toBe('true');
+
+      req.flush({});
+    });
+
     it('getFilteredData: should concatenate url with filter params', done => {
       const urlWithParams = 'http://mockurl.com?param1=value1&param2=value2&filter=test';
       const parsedParams: Array<PoComboOption> = [{ label: 'value1', value: 'value1' }];
@@ -183,6 +201,25 @@ describe('PoComboFilterService ', () => {
       httpMock.expectOne(`http://mockurl.com?filter=`).flush({ items });
     });
 
+    it('getObjectByValue: should contains X-PO-NO-MESSAGE in headers request', done => {
+      const filteredObject: PoComboOption = { label: 'value1', value: 'value1' };
+      const param = 'angular';
+      const urlWithParams = 'http://mockurl.com/angular';
+
+      spyOn(comboService, <any>'parseToComboOption').and.returnValue(filteredObject);
+      spyOnProperty(comboService, 'url', 'get').and.returnValue('http://mockurl.com');
+
+      comboService.getObjectByValue(param).subscribe(response => {
+        expect(response).toEqual(filteredObject);
+        done();
+      });
+
+      const req = httpMock.expectOne((request: HttpRequest<any>) => request.urlWithParams === urlWithParams);
+      expect(req.request.headers.get('X-PO-No-Message')).toBe('true');
+
+      req.flush({});
+    });
+
     it('getObjectByValue: should add filter params', done => {
       const filteredObject: PoComboOption = { label: 'value1', value: 'value1' };
       const param = 'angular';

projects/ui/src/lib/components/po-field/po-combo/po-combo-filter.service.ts

@@ -1,4 +1,4 @@
-import { HttpClient } from '@angular/common/http';
+import { HttpClient, HttpHeaders } from '@angular/common/http';
 import { Injectable } from '@angular/core';
 
 import { Observable } from 'rxjs';
@@ -25,6 +25,10 @@ export class PoComboFilterService implements PoComboFilter {
 
   private messages = [];
 
+  readonly headers: HttpHeaders = new HttpHeaders({
+    'X-PO-No-Message': 'true'
+  });
+
   get url(): string {
     return this._url;
   }
@@ -38,15 +42,15 @@ export class PoComboFilterService implements PoComboFilter {
     const params = { ...filterParamsValidated, filter: value };
 
     return this.http
-      .get(`${this.url}`, { responseType: 'json', params: params })
+      .get(`${this.url}`, { responseType: 'json', params, headers: this.headers })
       .pipe(map((response: PoResponse) => this.parseToArrayComboOption(response.items)));
   }
 
   getObjectByValue(value: string | number, filterParams?: any): Observable<PoComboOption> {
     const filterParamsValidated = validateObjectType(filterParams);
 
     return this.http
-      .get(`${this.url}/${value}`, { params: filterParamsValidated })
+      .get(`${this.url}/${value}`, { params: filterParamsValidated, headers: this.headers })
       .pipe(map(item => this.parseToComboOption(item)));
   }
 

projects/ui/src/lib/components/po-field/po-combo/po-combo.component.spec.ts

@@ -3,7 +3,7 @@ import { ComponentFixture, fakeAsync, TestBed, tick } from '@angular/core/testin
 import { HttpClient, HttpHandler } from '@angular/common/http';
 import { HttpClientTestingModule, HttpTestingController } from '@angular/common/http/testing';
 
-import { Observable } from 'rxjs';
+import { Observable, throwError } from 'rxjs';
 
 import { changeBrowserInnerWidth, configureTestSuite } from './../../../util-test/util-expect.spec';
 
@@ -1222,12 +1222,9 @@ describe('PoComboComponent:', () => {
       expect(component.isServerSearching).toBe(true);
     });
 
-    it('isServerSearching: should call `removeListeners` if isServerSearching is false', () => {
-      const spyRemoveListeners = spyOn(component, <any>'removeListeners');
-
+    it('isServerSearching: should set isServerSearching with false', () => {
       component.isServerSearching = false;
 
-      expect(spyRemoveListeners).toHaveBeenCalled();
       expect(component.isServerSearching).toBe(false);
     });
 
@@ -1718,6 +1715,35 @@ describe('PoComboComponent - with service:', () => {
       expect(fakeThis.service.getFilteredData).toHaveBeenCalledWith(param, filterParams);
     });
 
+    it('applyFilter: should set isServerSearching and call controlComboVisibility with false if getFilteredData throw error', () => {
+      const value = 'test';
+      const error = { 'error': { 'message': 'message' } };
+
+      spyOn(component, 'controlComboVisibility');
+      spyOn(component.service, 'getFilteredData').and.returnValue(throwError(error));
+
+      component.applyFilter(value);
+      fixture.detectChanges();
+
+      expect(component.service.getFilteredData).toHaveBeenCalled();
+      expect(component.isServerSearching).toBe(false);
+      expect(component.visibleOptions).toEqual([]);
+      expect(component.controlComboVisibility).toHaveBeenCalledWith(true);
+    });
+
+    it('getObjectByValue: should call updateSelectedValue with null if getObjectByValue throw error', () => {
+      const value = 'XPTO';
+      const error = { 'error': { 'message': 'message' } };
+
+      spyOn(component.service, 'getObjectByValue').and.returnValue(throwError(error));
+      spyOn(component, 'updateSelectedValue');
+
+      component.getObjectByValue(value);
+
+      expect(component.updateSelectedValue).toHaveBeenCalledWith(null);
+      expect(component.service.getObjectByValue).toHaveBeenCalled();
+    });
+
     it(`getObjectByValue: should call PoComboFilterService.getObjectByValue() with param and filterParam if
       selectedValue is invalid`, () => {
       const filterParams = 'filter';
@@ -1921,6 +1947,25 @@ describe('PoComboComponent - with service:', () => {
       expect(spyUpdateComboList).toHaveBeenCalledWith([...component.cacheOptions]);
     });
   });
+
+  describe('Templates:', () => {
+    it('should display `.po-combo-container-no-data` if error in filtered data', () => {
+      const value = 'test';
+      const error = { 'error': { 'message': 'message' } };
+
+      component.options = [
+        { value: 1, label: 'John Doe' },
+        { value: 2, label: 'Jane Doe' }
+      ];
+
+      spyOn(component.service, 'getFilteredData').and.returnValue(throwError(error));
+
+      component.applyFilter(value);
+      fixture.detectChanges();
+
+      expect(fixture.debugElement.query(By.css('.po-combo-container-no-data'))).toBeTruthy();
+    });
+  });
 });
 
 function getFakeService(item): any {

projects/ui/src/lib/components/po-field/po-combo/po-combo.component.ts

@@ -146,8 +146,6 @@ export class PoComboComponent extends PoComboBaseComponent implements AfterViewI
       this.initializeListeners();
     } else {
       this._isServerSearching = value;
-
-      this.removeListeners();
     }
   }
 
@@ -346,9 +344,10 @@ export class PoComboComponent extends PoComboBaseComponent implements AfterViewI
 
     const param = { property: this.fieldLabel, value };
 
-    this.filterSubscription = this.service
-      .getFilteredData(param, this.filterParams)
-      .subscribe(items => this.setOptionsByApplyFilter(value, items));
+    this.filterSubscription = this.service.getFilteredData(param, this.filterParams).subscribe(
+      items => this.setOptionsByApplyFilter(value, items),
+      error => this.onErrorFilteredData()
+    );
   }
 
   setOptionsByApplyFilter(value, items) {
@@ -373,9 +372,10 @@ export class PoComboComponent extends PoComboBaseComponent implements AfterViewI
     if (!this.selectedValue) {
       this.isProcessingGetObjectByValue = true;
 
-      this.getSubscription = this.service
-        .getObjectByValue(value, this.filterParams)
-        .subscribe(item => this.updateOptionByFilteredValue(item));
+      this.getSubscription = this.service.getObjectByValue(value, this.filterParams).subscribe(
+        item => this.updateOptionByFilteredValue(item),
+        error => this.onErrorGetObjectByValue()
+      );
     }
   }
 
@@ -608,6 +608,18 @@ export class PoComboComponent extends PoComboBaseComponent implements AfterViewI
     window.addEventListener('scroll', this.onScroll, true);
   }
 
+  private onErrorGetObjectByValue() {
+    this.updateOptionByFilteredValue(null);
+  }
+
+  private onErrorFilteredData() {
+    this.isServerSearching = false;
+
+    this.updateComboList([]);
+
+    this.controlComboVisibility(true);
+  }
+
   private onScroll = (): void => {
     this.adjustContainerPosition();
   };