fix(build): corrige erros de compilação com --prod

Ao compilar uma aplicação com AOT que contem o atributo fullTemplateTypeCheck no tsconfig ocorriam erros de acesso no HTML.

Fixes DTHFUI-1427

Author: Samir Hassan Ayoub

projects/templates/src/lib/components/po-modal-password-recovery/po-modal-password-recovery-base.component.ts

@@ -76,7 +76,7 @@ export abstract class PoModalPasswordRecoveryBaseComponent {
     emailSentConfirmationPhrase: string, emailSentTitle: string, forgotPasswordTitle: string,
     insertCode: string, insertEmail: string, insertPhone: string, phoneErrorMessagePhrase: string,
     prepositionIn: string, prepositionOr: string, recoveryPasswordPhrase: string, resendEmailButton: string,
-    resendSmsCodePhrase: string, sendAgain: string, sendButton: string, sms: string, smsCode: string,
+    resendSmsCodePhrase: string, sendAgain: string, sendAgainPhrase: string, sendButton: string, sms: string, smsCode: string,
     smsCodeErrorMessagePhrase: string, sentSmsCodePhrase: string, supportContact: string, telephone: string, typeCodeTitle: string } =
     {
       ...poModalPasswordRecoveryLiterals[poLocaleDefault],

projects/templates/src/lib/components/po-modal-password-recovery/po-modal-password-recovery.component.spec.ts

@@ -994,9 +994,7 @@ describe('PoModalPasswordRecoveryComponent:', () => {
     });
 
     it('should show `email/sms` fields content if modalType value is `Email`', () => {
-      component.emailModalPhrases = {
-        firstPhrase: 'Phrase'
-      };
+      component.emailModalPhrases.firstPhrase = 'Phrase';
       component.modalType = PoModalPasswordRecoveryModalContent.Email;
       component.type = PoModalPasswordRecoveryType.All;
 
@@ -1005,15 +1003,14 @@ describe('PoModalPasswordRecoveryComponent:', () => {
 
       const expectedContent = fixture.debugElement.query(By.css('.po-modal-password-recovery-text')).nativeElement;
 
-      expect(expectedContent.innerHTML).toContain(component.emailModalPhrases['firstPhrase']);
+      expect(expectedContent.innerHTML).toContain(component.emailModalPhrases.firstPhrase);
       expect(expectedContent.innerHTML).not.toContain(component.literals.sentSmsCodePhrase);
       expect(expectedContent.innerHTML).not.toContain(component.literals.emailSentConfirmationPhrase);
     });
 
     it('should show `smsCode` field content if modalType value is `SMSCode`', () => {
-      component.emailModalPhrases = {
-        firstPhrase: 'Phrase'
-      };
+      component.emailModalPhrases.firstPhrase = 'Phrase';
+
       component.modalType = PoModalPasswordRecoveryModalContent.SMSCode;
       component.type = PoModalPasswordRecoveryType.Email;
 
@@ -1023,14 +1020,12 @@ describe('PoModalPasswordRecoveryComponent:', () => {
       const expectedContent = fixture.debugElement.query(By.css('.po-modal-password-recovery-text')).nativeElement;
 
       expect(expectedContent.innerHTML).toContain(component.literals.sentSmsCodePhrase);
-      expect(expectedContent.innerHTML).not.toContain(component.emailModalPhrases['firstPhrase']);
+      expect(expectedContent.innerHTML).not.toContain(component.emailModalPhrases.firstPhrase);
       expect(expectedContent.innerHTML).not.toContain(component.literals.emailSentConfirmationPhrase);
     });
 
     it('should show `smsCode` field content if modalType value is `Confirmation`', () => {
-      component.emailModalPhrases = {
-        firstPhrase: 'Phrase'
-      };
+      component.emailModalPhrases.firstPhrase = 'Phrase';
       component.modalType = PoModalPasswordRecoveryModalContent.Confirmation;
       component.type = PoModalPasswordRecoveryType.Email;
 
@@ -1041,7 +1036,7 @@ describe('PoModalPasswordRecoveryComponent:', () => {
 
       expect(expectedContent.innerHTML).toContain(component.literals.emailSentConfirmationPhrase);
       expect(expectedContent.innerHTML).not.toContain(component.literals.sentSmsCodePhrase);
-      expect(expectedContent.innerHTML).not.toContain(component.emailModalPhrases['firstPhrase']);
+      expect(expectedContent.innerHTML).not.toContain(component.emailModalPhrases.firstPhrase);
     });
 
     it('should contain `po-field-container-error-text` class if `invalidEmail` and control are true', () => {

projects/templates/src/lib/components/po-modal-password-recovery/po-modal-password-recovery.component.ts

@@ -44,7 +44,7 @@ export class PoModalPasswordRecoveryComponent extends PoModalPasswordRecoveryBas
   codeMask: string = '9 9 9 9 9 9';
   control: AbstractControl;
   emailModal: boolean = true;
-  emailModalPhrases = {};
+  emailModalPhrases = { firstPhrase: null as string, secondPhrase: null as string };
   endpoint: string = '.';
   invalidCode: boolean = false;
   invalidEmail: boolean = false;
@@ -196,11 +196,11 @@ export class PoModalPasswordRecoveryComponent extends PoModalPasswordRecoveryBas
 
   private pipeModalPhrases() {
     if (this.type === PoModalPasswordRecoveryType.SMS) {
-      this.emailModalPhrases['firstPhrase'] = this.setPipeArguments(this.literals.recoveryPasswordPhrase, this.literals.sms);
-      this.emailModalPhrases['secondPhrase'] = this.setPipeArguments(this.literals.supportContact, this.literals.telephone);
+      this.emailModalPhrases.firstPhrase = this.setPipeArguments(this.literals.recoveryPasswordPhrase, this.literals.sms);
+      this.emailModalPhrases.secondPhrase = this.setPipeArguments(this.literals.supportContact, this.literals.telephone);
     } else {
-      this.emailModalPhrases['firstPhrase'] = this.setPipeArguments(this.literals.recoveryPasswordPhrase, this.literals.email);
-      this.emailModalPhrases['secondPhrase'] = this.setPipeArguments(this.literals.supportContact, this.literals.email);
+      this.emailModalPhrases.firstPhrase = this.setPipeArguments(this.literals.recoveryPasswordPhrase, this.literals.email);
+      this.emailModalPhrases.secondPhrase = this.setPipeArguments(this.literals.supportContact, this.literals.email);
     }
   }
 

projects/templates/src/lib/components/po-page-change-password/po-page-change-password.component.ts

@@ -58,8 +58,8 @@ export class PoPageChangePasswordComponent extends PoPageChangePasswordBaseCompo
 
   readonly literals: { backButton: string, confirmPassword: string, createNewPassword: string, createNewPasswordPhrase: string,
     currentPassword: string, enterSystemButton: string, forgotPassword: string, newPassword: string, passwordSuccessfullyCreated: string,
-    passwordSuccessfullyUpdated: string, safetyTips: string, safetyTipsPhrase: string, safetyTipsFirst: string, safetyTipsSecond: string,
-    safetyTipsThird: string, saveButton: string } =
+    passwordSuccessfullyUpdated: string, requirements: string, safetyTips: string, safetyTipsPhrase: string, safetyTipsFirst: string,
+    safetyTipsSecond: string, safetyTipsThird: string, saveButton: string } =
     {
       ...poPageChangePasswordLiterals[poLocaleDefault],
       ...poPageChangePasswordLiterals[browserLanguage()],

projects/templates/src/lib/components/po-page-dynamic-edit/po-page-dynamic-edit.component.ts

@@ -299,6 +299,10 @@ export class PoPageDynamicEditComponent implements OnInit {
     return this._detailFields;
   }
 
+  detailActionNew() {
+    this.gridDetail.insertRow();
+  }
+
   private cancel(path) {
     if (this.dynamicForm && this.dynamicForm.form.dirty) {
       this.poDialogService.confirm({
@@ -369,10 +373,6 @@ export class PoPageDynamicEditComponent implements OnInit {
     }
   }
 
-  private detailActionNew() {
-    this.gridDetail.insertRow();
-  }
-
   private resolveUrl(item: any, path: string) {
     const uniqueKey = this.formatUniqueKey(item);
 

projects/templates/src/lib/components/po-page-login/interfaces/po-page-login-literals.interface.ts

@@ -7,6 +7,12 @@
  */
 export interface PoPageLoginLiterals {
 
+  /** Mensagem de erro apresentada quando o campo customizado está inválido */
+  customFieldErrorPattern?: string;
+
+  /** Placeholder para o campo customizado. */
+  customFieldPlaceholder?: string;
+
   /** Título exibido no topo da página. */
   title?: string;
 

projects/templates/src/lib/components/po-page-login/po-page-login-base.component.ts

@@ -169,6 +169,7 @@ export abstract class PoPageLoginBaseComponent implements OnDestroy {
   customizedDefaultLiterals: PoPageLoginLiterals = {};
   loginSubscription: Subscription;
   password: string;
+  rememberUser: boolean = false;
   selectedLanguage: string;
   showExceededAttemptsWarning = false;
 
@@ -190,7 +191,6 @@ export abstract class PoPageLoginBaseComponent implements OnDestroy {
   private _registerUrl: string;
   private _urlRecovery: string;
 
-  protected rememberUser: boolean = false;
 
   /**
    * @optional

projects/templates/src/lib/components/po-page-login/po-page-login.component.ts

@@ -96,6 +96,23 @@ export class PoPageLoginComponent extends PoPageLoginBaseComponent implements Af
     }
   }
 
+  openUrl(recovery: any): void {
+    switch (typeof recovery) {
+      case 'string': {
+        this.setUrlRedirect(recovery);
+        break;
+      }
+      case 'function': {
+        recovery();
+        break;
+      }
+      case 'object': {
+        this.createModalPasswordRecoveryComponent(recovery);
+        break;
+      }
+    }
+  }
+
   private checkingForMetadataProperty(object, property) {
     if (Object.prototype.hasOwnProperty.call(object, property)) {
       return object[property];
@@ -187,23 +204,6 @@ export class PoPageLoginComponent extends PoPageLoginBaseComponent implements Af
     });
   }
 
-  protected openUrl(recovery: any): void {
-    switch (typeof recovery) {
-      case 'string': {
-        this.setUrlRedirect(recovery);
-        break;
-      }
-      case 'function': {
-        recovery();
-        break;
-      }
-      case 'object': {
-        this.createModalPasswordRecoveryComponent(recovery);
-        break;
-      }
-    }
-  }
-
   protected setLoginErrors(errors: Array<string>) {
     const control = this.loginForm.form.controls['login'];
     this.setControlErrors('allLoginErrors', control, errors, this.literals.loginErrorPattern);

projects/templates/tsconfig.lib.json

@@ -15,7 +15,7 @@
     "annotateForClosureCompiler": true,
     "skipTemplateCodegen": true,
     "strictMetadataEmit": true,
-    "fullTemplateTypeCheck": false,
+    "fullTemplateTypeCheck": true,
     "strictInjectionParameters": true,
     "enableResourceInlining": true
   },

projects/ui/src/lib/components/po-calendar/po-calendar-base.component.ts

@@ -44,11 +44,13 @@ export class PoCalendarBaseComponent {
   private _maxDate: Date;
   private _minDate: Date;
 
+  currentYear: number;
   dayVisible: boolean = false;
   displayDays: Array<number>;
   displayDecade: Array<number>;
   displayFinalDecade: number;
   displayMonth: any;
+  displayMonthNumber: number;
   displayMonths: Array<any> = Array();
   displayStartDecade: number;
   displayWeekDays: Array<any> = Array();
@@ -57,10 +59,8 @@ export class PoCalendarBaseComponent {
   yearVisible: boolean = false;
 
   protected currentMonthNumber: number;
-  protected currentYear: number;
   protected date: Date;
   protected dateIso: string;
-  protected displayMonthNumber: number;
   protected lastDisplay: string;
   protected onTouched: any = null;
   protected propagateChange: any = null;