This repository was archived by the owner on Jul 19, 2022. It is now read-only.
Following the Node convention with the err argument. #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Write test for an error case inside app auth.
lib/auth.js
Outdated
Contributor
There was a problem hiding this comment.
We need to pass the err all the way to the top, like this: https://github.com/podio/podio-js/blob/master/lib/auth.js#L104
Contributor
Author
There was a problem hiding this comment.
You're right, was assuming that _authenticate will call the callback itself, but we don't pass it the callback. Will fix
srn
pushed a commit
that referenced
this pull request
May 12, 2015
Following the Node convention with the err argument.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.