Version 1.6.3 Woes

[mario-luis-dev]

Just updated the package to 1.6.3, and surprise surprise, the code wouldn't compile. The culprit? The "Modernize package" changes made it so that I had to explicitly import GRDB in 75 files, due to the SWIFT_UPCOMING_FEATURE_MEMBER_IMPORT_VISIBILITY property in the build settings. Not the first time you guys ship a breaking change on a minor release (last time it was 1.6.1 if I recall correctly); it's irritating to say the least...

[mbrandonw]

Hi @mario-luis-dev, we'd appreciate if you find a better way to communicate with us. This kind of tone is not likely to convince us to help out much.

And all of the examples and case studies in the repo compile just fine, and so we are not aware of any breaking change. You will need to actually show us the breaking change for us to do anything about it. The most helpful thing you can do when reporting an issue is provide an actual minimal project that reproduces the problem. Without that we have nothing to work off of.

[mbrandonw]

Hi @mario-luis-dev, any update on this? Are you able to share some concrete info about the problems you are seeing? I am not able to reproduce this in any of our sample code, but we of course do want to fix this if there is a legitimate problem.

[mario-luis-dev]

@mbrandonw I solved the problem by explicitly importing GRDB in all the files (prior to 1.6.3 just importing SQLiteData was enough). As for how to reproduce it, you should be able to do so if you have the "upcoming features" flag I mentioned in the post enabled; I always have Swift 6 with strict concurrency and upcoming Swift features always enabled in all my projects.

[mbrandonw]

Hi @mario-luis-dev, none of the demo apps or case studies in this repo exhibit the problem that you are describing. And as you can see, we are re-exporting all of GRDB's symbols that are necessary. So I currently do not see a breaking change.

If you are going to start a passive-aggressive discussion then you will need to provide an actual project that compiles in SQLiteData <1.6.3 but does not compile in 1.6.3. It is the only way we can possibly investigate the problem without more information.

As for how to reproduce it, you should be able to do so if you have the "upcoming features" flag I mentioned in the post enabled

Wait, so it is your project that has "MemberImportVisibility" turned on? I'm sorry to say but we do not consider that a breaking change whatsoever. You have decided to enable strict settings in your projects and so you take responsibility of keeping your imports clean. We decided to clean up in the imports in our package, and therefore it trickled out to yours. That is the reality of using that setting, and if you are not ready for the responsibility you can disable it in your own project.

[stephencelis]

I was able to reproduce the issue. I'm not sure when and why it occurs, but seems related to @_exported flakily interacting with the newer Swift features.

@mario-luis-dev Can you try #477 and report back? We can merge and cut a release soon if it fixes things for you.

[mario-luis-dev]

I was able to reproduce the issue. I'm not sure when and why it occurs, but seems related to @_exported flakily interacting with the newer Swift features.

@mario-luis-dev Can you try #477 and report back? We can merge and cut a release soon if it fixes things for you.

Thanks Stephen. I'll give it a try tomorrow and report back. I had already moved on though, and simply accepted that I had to explicitly import GRDB; I mean it's not a big deal, it was mostly just the shock of seeing 70+ errors coming from that many files simply because I had to add the explicit import line.