Avoid watchOS test crash #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've been using `DispatchQueue`'s `setSpecific` and `getSpecific` to detect the main queue, but this doesn't seem to work in watchOS (or maybe I've been holding it wrong). I think in our case we really only care if we're on the main thread, so I'm hoping a `Thread.isMainThread` is enough. If this fix is appropriate we should apply it to other repos that rely on this, as well, like SnapshotTesting. Fixes #120
mbrandonw
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been using
DispatchQueue'ssetSpecificandgetSpecificto detect the main queue, but this doesn't seem to work in watchOS (or maybe I've been holding it wrong). I think in our case we really only care if we're on the main thread, so I'm hoping aThread.isMainThreadis enough.If this fix is appropriate we should apply it to other repos that rely on this, as well, like SnapshotTesting.
Fixes #120