-
Notifications
You must be signed in to change notification settings - Fork 164
@DependencyClient macro
#132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
Show all changes
49 commits
Select commit
Hold shift + click to select a range
590d30b
wip
stephencelis d2f35d1
wip
stephencelis 5a6e1c3
fix
stephencelis b53ebe2
wip
stephencelis f9e78d7
wip
stephencelis a90d494
wip
stephencelis 59cd6df
wip
stephencelis dd1d027
wip
stephencelis d57c164
wip
stephencelis 6233b5b
ranges
mbrandonw 0fba1e5
docs
mbrandonw a3e8db8
wip
stephencelis 614a9fc
wip
mbrandonw a32f204
wip
stephencelis d64f1a2
wip
stephencelis 31e2a56
wip
stephencelis 48e1711
fix
stephencelis 51a828f
wip
stephencelis 85402d2
customizable method name
mbrandonw cd77f03
docs for @DependencyEndpoint
mbrandonw 667ca77
clean up code
mbrandonw ba4b3b4
wip
mbrandonw fdc8aff
fix
mbrandonw 9d5ba24
fixes
mbrandonw f300299
validate method
stephencelis fc53106
wip
stephencelis 9112233
wip
stephencelis 7dd49c0
add test
mbrandonw 4993178
add test
mbrandonw ec6e00e
apply availability even when using @DependencyEndpoint(method:)
mbrandonw b79421e
wip
mbrandonw 1f8dfc5
wip
stephencelis e763327
wip
stephencelis a2381bd
wip
stephencelis a0cbe0d
wip
stephencelis f660c88
wip
stephencelis e92c082
wip
stephencelis d82952b
docs fix
mbrandonw 0f86009
wip
stephencelis c6d1faf
wip
stephencelis f0c28c8
wip
stephencelis 3cd33cd
wip
stephencelis 1dc21bd
wip
stephencelis 32872c4
wip
stephencelis 1dc3a53
Handle escaped identifiers correctly.
mbrandonw 2ca782b
update diagnostic
mbrandonw e28790e
wip
stephencelis cf97576
updated gotchas
mbrandonw 8778818
Disable windows and integration tests.
mbrandonw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| version: 1 | ||
| builder: | ||
| configs: | ||
| - documentation_targets: | ||
| - Dependencies | ||
| - DependenciesMacros | ||
| swift_version: 5.9 |
27 changes: 27 additions & 0 deletions
27
Dependencies.xcworkspace/xcshareddata/swiftpm/Package.resolved
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @brianmichel, we've been experiencing flakiness with windows CI and so have been slowly disabling them. Not sure if this is something you want to look into eventually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @mbrandonw sorry for the delay, we're in burn down mode for getting the first version of the Windows app out to a few folks, I'm not exactly sure what's going on here, but have a personal todo to take a peek once I have more free time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @brianmichel, no problem at all! We're happy to turn it back on when possible, but definitely not urgent. Thanks for responding!