Skip to content

Conversation

@mbrandonw
Copy link
Member

Fixes #155.

@xiii111
Copy link
Contributor

xiii111 commented Dec 10, 2023

@mbrandonw #155 (comment)

so if I can't finish it by the end of this week, I'll reach out to let you know.

I apologize for not being able to communicate the delay. Thank you for the pull request.
I've also been attempting to fix the bug on my end (haven't created a pull request yet), and it's similar to your fix. Thank you.

@mbrandonw
Copy link
Member Author

Hey @xiii111, sorry about that. I didn't catch that comment. If you've got a PR ready I'll close mine!

@xiii111
Copy link
Contributor

xiii111 commented Dec 10, 2023

Hi @mbrandonw, I am very grateful for your consideration. I will submit a pull request within 24 hours, but essentially it is the same as your change. Therefore, I have no hesitation in merging your pull request. Please proceed as you see fit.

@xiii111
Copy link
Contributor

xiii111 commented Dec 10, 2023

@mbrandonw I opened #160. Could you check it?

@mbrandonw
Copy link
Member Author

Closing in favor of #160.

@mbrandonw mbrandonw closed this Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@DependencyClient and @autoclosure parameters

3 participants