Skip to content

Xcode 16 beta 5: look up macros from current test trait #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 9, 2024
Merged

Xcode 16 beta 5: look up macros from current test trait #29

merged 1 commit into from
Aug 9, 2024

Conversation

@noremac
Copy link
Contributor

@noremac noremac commented Aug 9, 2024

I was trying out the experimental swift testing support and was getting errors that I had not configured any macros for testing. Traced it back to the assertMacro function not falling back to Test.current?.macros.

stephencelis
stephencelis approved these changes Aug 9, 2024
View reviewed changes
Copy link
Member

@stephencelis stephencelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@stephencelis stephencelis merged commit c33adc7 into pointfreeco:main Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stephencelis stephencelis stephencelis approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@noremac @stephencelis