Make erroneous @DatabaseFunction applications easier to debug
#219
+67
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The macro has to make assumptions about the types involved in the function, _i.e._ that they are "query representable." We rely on a `_columnWidth` property that produces the following, unhelpful error when dealing with types that aren't representable in queries: > Type 'CKShare' has no member '_columnWidth' By moving things to a function, the error provides better breadcrumbs: > Global function '_columnWidth' requires that 'CKShare' conform to > 'QueryExpression' The compiler generates more instructions here, but `_columnWidth` is only called a single time for database functions at the time of installation. The other fix is for `decode`, which is heavily overloaded, so the existing error: > No exact matches in call to instance method 'decode' Gets deemphasized for: > Global function '_requireQueryRepresentable' requires that 'Foo' > conform to 'QueryRepresentable'
mbrandonw
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The macro has to make assumptions about the types involved in the function, i.e. that they are "query representable." We rely on a
_columnWidthproperty that produces the following, unhelpful error when dealing with types that aren't representable in queries:By moving things to a function, the error provides better breadcrumbs:
The compiler generates more instructions here, but
_columnWidthis only called a single time for database functions at the time of installation.The other fix is for
decode, which is heavily overloaded, so the existing error:Gets deemphasized for: