Skip to content

fix: lossless has too many /online logs, make no change status as debug logs #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 14, 2024
Merged

fix: lossless has too many /online logs, make no change status as debug logs #474

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
bbd8aa6
feat: support lossless event logs
andrewshan Mar 8, 2024
01aae77
feat: 无损上下线增加实例参数
andrewshan Mar 9, 2024
9c92502
fix: add unit test case
andrewshan Mar 9, 2024
110a5b2
Merge pull request #1 from polarismesh/main
andrewshan Mar 9, 2024
e047ead
fix: when register statuses is empty, set unregistered
andrewshan Mar 11, 2024
e0ef7b3
Merge pull request #2 from polarismesh/main
andrewshan Mar 11, 2024
8a95c9a
fix: too many /online log printing
andrewshan Mar 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion .../java/com/tencent/polaris/plugin/lossless/register/HealthCheckRegisterLosslessPolicy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,13 +242,24 @@ public Map<String, HttpHandler> getHandlers() {
}
Map<String, HttpHandler> handlers = new HashMap<>();
handlers.put(ONLINE_PATH, new HttpHandler() {

private RegisterStatus lastFinalStatus;

@Override
public void handle(HttpExchange exchange) throws IOException {
Map<BaseInstance, LosslessActionProvider> actionProviders = valueContext.getValue(LosslessActionProvider.CTX_KEY);
Map<BaseInstance, RegisterStatus> registerStatuses = valueContext.getValue(CTX_KEY_REGISTER_STATUS);
Set<BaseInstance> instances = actionProviders.keySet();
LOG.info("[HealthCheckRegisterLosslessPolicy] receive /online request, check register status for instances {}", instances);
RegisterStatus finalStatus = checkRegisterStatus(instances, registerStatuses);
if (finalStatus != lastFinalStatus) {
LOG.info("[HealthCheckRegisterLosslessPolicy] receive /online request for instances {}, " +
"finalStatus from {} to {}", instances, lastFinalStatus, finalStatus);
// 最终一致性，无需做多线程保护
lastFinalStatus = finalStatus;
} else {
LOG.debug("[HealthCheckRegisterLosslessPolicy] receive /online request for instances {}, " +
"finalStatus from {} to {}", instances, lastFinalStatus, finalStatus);
}
HttpServerUtils.writeTextToHttpServer(
exchange, finalStatus.toString(), finalStatus == RegisterStatus.REGISTERED ? 200 : 404);
}
Expand Down