-
Notifications
You must be signed in to change notification settings - Fork 71
Add Polkadart to tooling section #944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Polkadart to tooling section #944
Conversation
|
Also @leonardocustodio, could you please make sure to push the updated llms file after you resolve the comments? You can do this by running: python scripts/generate_llms.pyThen, commit and push the updated llms-related files. |
Co-authored-by: Nicolás Hussein <80422357+nhussein11@users.noreply.github.com>
…olkadart' into leonardocustodio/add-polkadart
|
Great, thanks for letting me know. I've updated the LLMs file and also made a commit with the feedback 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @leonardocustodio ,
I left some minor edits, but overall it looks great. Besides those suggestion. the only feature that I would like to ask would be adding an entry for this page in the .nav.yml that exists in this directory /develop/toolkit/api-libraries so that your work is reachable on the left navigation.
So adding in the .nav something like - ':simple-dart: Polkadart': polkadart.md after the Polkadot.js API.
Co-authored-by: Taylor Lucero <67010424+Telucero@users.noreply.github.com>
Co-authored-by: Taylor Lucero <67010424+Telucero@users.noreply.github.com>
Co-authored-by: Taylor Lucero <67010424+Telucero@users.noreply.github.com>
Co-authored-by: Taylor Lucero <67010424+Telucero@users.noreply.github.com>
Co-authored-by: Taylor Lucero <67010424+Telucero@users.noreply.github.com>
Co-authored-by: Taylor Lucero <67010424+Telucero@users.noreply.github.com>
Thank you, sir, for the feedback. made all the changes, let me know if there is anything else 🫡 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
Hey guys, just checking, how does the merge process work? Is there a release cycle or something? |
Hi @leonardocustodio! Yes, we do a batch release every week. We didn't do one last week because we were on a team retreat, but we'll include this PR in this week's release :). |

No description provided.