Skip to content

Conversation

@leonardocustodio
Copy link
Contributor

No description provided.

@leonardocustodio leonardocustodio requested a review from a team as a code owner August 30, 2025 00:23
@eshaben eshaben requested a review from a team September 4, 2025 15:12
@nhussein11 nhussein11 added B0 - Needs Review Pull request is ready for review C1 - Medium Medium priority task A0 - New Content Pull request contains new content pages labels Sep 8, 2025
@nhussein11
Copy link
Collaborator

Also @leonardocustodio, could you please make sure to push the updated llms file after you resolve the comments? You can do this by running:

python scripts/generate_llms.py

Then, commit and push the updated llms-related files.

leonardocustodio and others added 3 commits September 8, 2025 17:37
Co-authored-by: Nicolás Hussein <80422357+nhussein11@users.noreply.github.com>
…olkadart' into leonardocustodio/add-polkadart
@leonardocustodio
Copy link
Contributor Author

Great, thanks for letting me know. I've updated the LLMs file and also made a commit with the feedback 😄

Copy link
Contributor

@Telucero Telucero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @leonardocustodio ,
I left some minor edits, but overall it looks great. Besides those suggestion. the only feature that I would like to ask would be adding an entry for this page in the .nav.yml that exists in this directory /develop/toolkit/api-libraries so that your work is reachable on the left navigation.

So adding in the .nav something like - ':simple-dart: Polkadart': polkadart.md after the Polkadot.js API.

leonardocustodio and others added 7 commits September 15, 2025 15:32
Co-authored-by: Taylor Lucero <67010424+Telucero@users.noreply.github.com>
Co-authored-by: Taylor Lucero <67010424+Telucero@users.noreply.github.com>
Co-authored-by: Taylor Lucero <67010424+Telucero@users.noreply.github.com>
Co-authored-by: Taylor Lucero <67010424+Telucero@users.noreply.github.com>
Co-authored-by: Taylor Lucero <67010424+Telucero@users.noreply.github.com>
Co-authored-by: Taylor Lucero <67010424+Telucero@users.noreply.github.com>
@leonardocustodio
Copy link
Contributor Author

Hi @leonardocustodio , I left some minor edits, but overall it looks great. Besides those suggestion. the only feature that I would like to ask would be adding an entry for this page in the .nav.yml that exists in this directory /develop/toolkit/api-libraries so that your work is reachable on the left navigation.

So adding in the .nav something like - ':simple-dart: Polkadart': polkadart.md after the Polkadot.js API.

Thank you, sir, for the feedback. made all the changes, let me know if there is anything else 🫡

@nhussein11 nhussein11 requested a review from Telucero September 18, 2025 11:13
Copy link
Contributor

@Telucero Telucero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image I think it looks good to go!

Copy link
Collaborator

@nhussein11 nhussein11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nhussein11 nhussein11 removed the B0 - Needs Review Pull request is ready for review label Sep 20, 2025
@nhussein11 nhussein11 added the B1 - Ready to Merge Pull request is ready to be merged label Sep 20, 2025
@leonardocustodio
Copy link
Contributor Author

Hey guys, just checking, how does the merge process work? Is there a release cycle or something?

@nhussein11
Copy link
Collaborator

Hey guys, just checking, how does the merge process work? Is there a release cycle or something?

Hi @leonardocustodio! Yes, we do a batch release every week. We didn't do one last week because we were on a team retreat, but we'll include this PR in this week's release :).

@nhussein11 nhussein11 merged commit b7c2755 into polkadot-developers:master Oct 2, 2025
1 check passed
@leonardocustodio leonardocustodio deleted the leonardocustodio/add-polkadart branch October 2, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A0 - New Content Pull request contains new content pages B1 - Ready to Merge Pull request is ready to be merged C1 - Medium Medium priority task

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants