feat(model): grid check with files#136
Merged
mostaphaRoudsari merged 1 commit intopollination:masterfrom May 16, 2023
Merged
Conversation
|
🎉 This PR is included in version 0.10.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
chriswmackey
added a commit
to chriswmackey/handlers-python
that referenced
this pull request
Sep 18, 2023
We used to have the Model handler set up such that, if you just connected up the file path to a HBJSON, the file would just get copied for upload without loading it into Python. [It seems that we changed this a few months ago](pollination@62fe930) but we should revert it since being able to plugin in a file path instead of a Model object and know that extra time wouldn't be spent saving or re-parsing it was really useful. From my understanding, the re-parsing routine was added a few months ago because of checks that we wanted to run from the Rhino plugin but, for a case like that, the check should be run on the .NET side where we have the Rhino plugin Model object in .NET form instead of writing a large .NET Model object to JSON, loading the model from JSON to Python, running the check in Python, and then writing the Model from Python back to JSON. [It's for cases like this that we have handlers that are written in .NET.](https://github.com/pollination/handlers-csharp)
chriswmackey
added a commit
that referenced
this pull request
Sep 18, 2023
We used to have the Model handler set up such that, if you just connected up the file path to a HBJSON, the file would just get copied for upload without loading it into Python. [It seems that we changed this a few months ago](62fe930) but we should revert it since being able to plugin in a file path instead of a Model object and know that extra time wouldn't be spent saving or re-parsing it was really useful. From my understanding, the re-parsing routine was added a few months ago because of checks that we wanted to run from the Rhino plugin but, for a case like that, the check should be run on the .NET side where we have the Rhino plugin Model object in .NET form instead of writing a large .NET Model object to JSON, loading the model from JSON to Python, running the check in Python, and then writing the Model from Python back to JSON. [It's for cases like this that we have handlers that are written in .NET.](https://github.com/pollination/handlers-csharp)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @mostaphaRoudsari