Upgrade to websockets 14+ and propagate ConnectionClosedError after max_reconnects #935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is failing since 3.8 is not supported anymore. We need to update the github action. So, I'll re-test this once we fix #936. |
penelopus
approved these changes
Oct 15, 2025
|
i approved this before noticing that the test for 3.8 is failing — can you take a look at that? |
justinpolygon
deleted the
feat/upgrade-websockets-14-fix-reconnect-error
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the WebSocket client to use websockets 14+ by switching to the new asyncio implementation (
websockets.asyncio.client), updating type hints toClientConnection, and addingprocess_exception=lambda exc: Noneto mimic legacy reconnection behavior on any error. It also fixes #818 by propagatingConnectionClosedErrorafter exceedingmax_reconnects, improving error handling without breaking user scripts. Requires Python 3.9+. Tested for compatibility; no end-user API changes.