CLI - asc should not be assumed globally available when running local build strategy#1382
Merged
dOrgJelli merged 1 commit intoorigin-0.10-devfrom Nov 2, 2022
Merged
Conversation
…sent as a global command
dOrgJelli
approved these changes
Nov 2, 2022
Contributor
|
Using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While running tests, I noticed that the
localbuild strategy was failing to build, giving me an output ofasc not found.Looking into
local.shI found out that the default build script assumes thatascis present as a global command (e.g.npm i -g typescript), whereas my setup did not have this.I have changed the script to assume that TS is present locally (
yarnshould take care of that) and switched to running it usingnpx asc...Let me know if this is something we don't want to have.