-
Couldn't load subscription status.
- Fork 24
Add Windows Build Compatibility #131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Ashish-Kumar-Dash
wants to merge
4
commits into
pooranjoyb:develop
Choose a base branch
from
Ashish-Kumar-Dash:feat/buildfw
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+176
−50
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,50 +1,58 @@ | ||
| cmake_minimum_required(VERSION 3.10) | ||
| project(AppwriteSDK CXX) | ||
| cmake_minimum_required(VERSION 3.15) | ||
| project(AppwriteSDK VERSION 1.0.0 LANGUAGES CXX) | ||
|
|
||
| set(CMAKE_CXX_STANDARD 11) | ||
| set(CMAKE_CXX_STANDARD 17) | ||
| set(CMAKE_CXX_STANDARD_REQUIRED ON) | ||
|
|
||
| include_directories(${CMAKE_BINARY_DIR}/conan/include) | ||
| link_directories(${CMAKE_BINARY_DIR}/conan/lib) | ||
| if(WIN32) | ||
| set(CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS ON) | ||
| add_definitions(-DWIN32_LEAN_AND_MEAN) | ||
| add_definitions(-DNOMINMAX) | ||
| endif() | ||
|
|
||
| find_package(CURL REQUIRED) | ||
| find_package(PkgConfig QUIET) | ||
|
|
||
| set(SRCS | ||
| src/Appwrite.cpp | ||
| src/services/Account.cpp | ||
| src/services/Query.cpp | ||
| src/services/Databases.cpp | ||
| src/services/Messaging.cpp | ||
| src/services/Storage.cpp | ||
| src/services/Health.cpp | ||
| src/Utils.cpp | ||
| src/Validator.cpp | ||
| ) | ||
| # Ensure CMake uses Conan's find modules for dependencies | ||
| if(EXISTS "${CMAKE_BINARY_DIR}/generators/CURLConfig.cmake") | ||
| list(PREPEND CMAKE_PREFIX_PATH "${CMAKE_BINARY_DIR}/generators") | ||
| endif() | ||
|
|
||
| add_library(AppwriteSDK STATIC ${SRCS}) | ||
| find_package(CURL REQUIRED) | ||
|
|
||
| include_directories(include) | ||
| file(GLOB_RECURSE SOURCES "${CMAKE_CURRENT_SOURCE_DIR}/src/*.cpp") | ||
| file(GLOB_RECURSE HEADERS "${CMAKE_CURRENT_SOURCE_DIR}/include/*.hpp" "${CMAKE_CURRENT_SOURCE_DIR}/include/*.h") | ||
|
|
||
| target_link_libraries(AppwriteSDK CURL::libcurl) | ||
| add_library(AppwriteSDK STATIC ${SOURCES}) | ||
|
|
||
| set_target_properties(AppwriteSDK PROPERTIES | ||
| ARCHIVE_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/lib | ||
| target_include_directories(AppwriteSDK | ||
| PUBLIC | ||
| $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include> | ||
| $<INSTALL_INTERFACE:include> | ||
| PRIVATE | ||
| ${CMAKE_CURRENT_SOURCE_DIR}/src | ||
| ) | ||
|
|
||
| set(HEADERS | ||
| include/Appwrite.hpp | ||
| include/classes/Account.hpp | ||
| include/classes/Query.hpp | ||
| include/classes/Databases.hpp | ||
| include/classes/Messaging.hpp | ||
| include/classes/Storage.hpp | ||
| include/classes/Health.hpp | ||
| include/config/Config.hpp | ||
| include/enums/HttpStatus.hpp | ||
| include/exceptions/AppwriteException.hpp | ||
| include/Utils.hpp | ||
| include/Validator.hpp | ||
| if(TARGET CURL::libcurl) | ||
| target_link_libraries(AppwriteSDK PUBLIC CURL::libcurl) | ||
| message(STATUS "AppwriteSDK: Linked with CURL::libcurl") | ||
| elseif(TARGET CURL::CURL) | ||
| target_link_libraries(AppwriteSDK PUBLIC CURL::CURL) | ||
| message(STATUS "AppwriteSDK: Linked with CURL::CURL") | ||
| else() | ||
| message(FATAL_ERROR "CURL library not found! Ensure Conan CMakeDeps configured correctly.") | ||
| endif() | ||
|
|
||
| if(WIN32) | ||
| target_link_libraries(AppwriteSDK PRIVATE ws2_32 wldap32 crypt32) | ||
| endif() | ||
|
|
||
| install(DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/include/ | ||
| DESTINATION include/AppwriteSDK | ||
| ) | ||
| install(TARGETS AppwriteSDK | ||
| ARCHIVE DESTINATION lib | ||
| LIBRARY DESTINATION lib | ||
| RUNTIME DESTINATION bin | ||
| ) | ||
|
|
||
| install(DIRECTORY include/ DESTINATION /usr/local/include/AppwriteSDK) | ||
| install(FILES ${HEADERS} DESTINATION /usr/local/include/AppwriteSDK) | ||
| install(TARGETS AppwriteSDK ARCHIVE DESTINATION /usr/local/lib) | ||
| message(STATUS "AppwriteSDK: Ready for install, all dependencies resolved.") | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| @echo off | ||
| echo AppwriteSDK Windows Build (Fixed) | ||
| echo ================================= | ||
|
|
||
| :: Ensure MinGW is in PATH | ||
| where gcc >nul 2>&1 | ||
| if %errorlevel% neq 0 ( | ||
| echo Error: GCC not found. Ensure MinGW is in your PATH. | ||
| pause | ||
| exit /b 1 | ||
| ) | ||
|
|
||
| :: Clean build directory | ||
| if exist "build" rmdir /s /q "build" | ||
| mkdir build | ||
| cd build | ||
|
|
||
| :: Install dependencies with explicit output folder | ||
| echo Installing dependencies with Conan... | ||
| conan install .. --output-folder=. --build=missing -s build_type=Release | ||
|
|
||
| :: Verify toolchain file was created | ||
| if exist "conan_toolchain.cmake" ( | ||
| echo ✅ Found conan_toolchain.cmake | ||
| set "TOOLCHAIN_FILE=conan_toolchain.cmake" | ||
| ) else ( | ||
| echo ❌ conan_toolchain.cmake not found, listing build contents: | ||
| dir /b | ||
| echo Trying without toolchain file... | ||
| set "TOOLCHAIN_FILE=" | ||
| ) | ||
|
|
||
| :: Configure with CMake | ||
| echo Configuring with CMake... | ||
| if defined TOOLCHAIN_FILE ( | ||
| cmake .. -G "MinGW Makefiles" -DCMAKE_TOOLCHAIN_FILE=%TOOLCHAIN_FILE% -DCMAKE_BUILD_TYPE=Release | ||
| ) else ( | ||
| cmake .. -G "MinGW Makefiles" -DCMAKE_BUILD_TYPE=Release | ||
| ) | ||
|
|
||
| if %errorlevel% neq 0 ( | ||
| echo ❌ CMake configuration failed | ||
| pause | ||
| exit /b 1 | ||
| ) | ||
|
|
||
| :: Build | ||
| echo Building... | ||
| cmake --build . --config Release | ||
|
|
||
| if %errorlevel% equ 0 ( | ||
| echo ✅ Build successful! | ||
| cd .. | ||
| call install_windows.bat | ||
| ) else ( | ||
| echo ❌ Build failed | ||
| pause | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| @PACKAGE_INIT@ | ||
|
|
||
| include(CMakeFindDependencyMacro) | ||
|
|
||
| find_dependency(CURL REQUIRED) | ||
| find_dependency(nlohmann_json REQUIRED) | ||
|
|
||
| include("${CMAKE_CURRENT_LIST_DIR}/AppwriteSDKTargets.cmake") | ||
|
|
||
| check_required_components(AppwriteSDK) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,9 @@ | ||
| [requires] | ||
| libcurl/8.10.1 | ||
| libcurl/7.87.0 | ||
|
|
||
| [generators] | ||
| CMakeDeps | ||
| CMakeToolchain | ||
|
|
||
| [layout] | ||
| cmake_layout | ||
| [options] | ||
| libcurl/*:shared=False |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| @echo off | ||
| echo Installing AppwriteSDK to MinGW directories... | ||
|
|
||
| :: Find MinGW installation | ||
| for /f "tokens=*" %%i in ('where gcc') do set "GCC_PATH=%%i" | ||
| for %%i in ("%GCC_PATH%") do set "MINGW_BIN=%%~dpi" | ||
| set "MINGW_ROOT=%MINGW_BIN:~0,-5%" | ||
|
|
||
| echo MinGW Root: %MINGW_ROOT% | ||
|
|
||
| :: Install headers | ||
| set "INCLUDE_DIR=%MINGW_ROOT%\include\AppwriteSDK" | ||
| if not exist "%INCLUDE_DIR%" mkdir "%INCLUDE_DIR%" | ||
| xcopy /E /I /Y "include\*" "%INCLUDE_DIR%\" | ||
|
|
||
| :: Install libraries | ||
| copy /Y "build\*.a" "%MINGW_ROOT%\lib\" 2>nul | ||
|
|
||
| echo Installation complete! | ||
| echo Headers installed to: %INCLUDE_DIR% | ||
| echo Libraries installed to: %MINGW_ROOT%\lib\ | ||
| echo. | ||
| echo Test compilation: g++ -o test.exe test.cpp -lAppwriteSDK | ||
| pause |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be 17 i guess, keeping the same as the current standard.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i have set the standard set as 17 only is there an issue?