Alphabetize imports (#2073)

Author: outoftime

.eslintrc.json

@@ -253,7 +253,8 @@
     "import/order": [
       "warn",
       {
-        "newlines-between": "always-and-inside-groups"
+        "newlines-between": "always-and-inside-groups",
+        "alphabetize": {"order": "asc", "caseInsensitive": true}
       }
     ],
     "import/unambiguous": "warn",
@@ -416,6 +417,10 @@
     "require-atomic-updates": "warn",
     "require-unicode-regexp": "warn",
     "require-yield": "error",
+    "sort-imports": [
+      "warn",
+      {"ignoreCase": true, "ignoreDeclarationSort": true}
+    ],
     "spaced-comment": ["warn", "always"],
     "strict": ["warn", "never"],
     "use-isnan": "warn",

__mocks__/@bugsnag/js.js

@@ -1,6 +1,6 @@
-import React, {Fragment} from 'react';
-import PropTypes from 'prop-types';
 import noop from 'lodash-es/noop';
+import PropTypes from 'prop-types';
+import React, {Fragment} from 'react';
 
 function ErrorBoundary({children}) {
   return React.createElement(Fragment, null, children);

gulpfile.js

@@ -1,20 +1,20 @@
 const fs = require('fs');
-const path = require('path');
 const https = require('https');
+const path = require('path');
 
+const BrowserSync = require('browser-sync');
+const cloudflare = require('cloudflare');
+const cssnano = require('cssnano');
 const gulp = require('gulp');
 const concat = require('gulp-concat');
+const postcss = require('gulp-postcss');
 const sourcemaps = require('gulp-sourcemaps');
-const cssnano = require('cssnano');
+const isDocker = require('is-docker');
 const forOwn = require('lodash.forown');
-const postcss = require('gulp-postcss');
+const pify = require('pify');
 const postcssPresetEnv = require('postcss-preset-env');
 const webpack = require('webpack');
 const webpackDevMiddleware = require('webpack-dev-middleware');
-const cloudflare = require('cloudflare');
-const BrowserSync = require('browser-sync');
-const pify = require('pify');
-const isDocker = require('is-docker');
 
 const config = require('./src/config');
 const webpackConfiguration = require('./webpack.config');

karma.conf.js

@@ -1,5 +1,5 @@
-const isDocker = require('is-docker');
 const commandExists = require('command-exists').sync;
+const isDocker = require('is-docker');
 
 const webpackConfiguration = require('./webpack.config.js');
 

src/actions/compiledProjects.js

@@ -1,5 +1,5 @@
-import {createAction} from 'redux-actions';
 import identity from 'lodash-es/identity';
+import {createAction} from 'redux-actions';
 
 export const projectCompiled = createAction(
   'PROJECT_COMPILED',

src/actions/console.js

@@ -1,5 +1,5 @@
-import {createAction} from 'redux-actions';
 import identity from 'lodash-es/identity';
+import {createAction} from 'redux-actions';
 import uuid from 'uuid/v4';
 
 export const consoleValueProduced = createAction(

src/actions/index.js

@@ -5,84 +5,80 @@ import {createAssignment} from './assignments';
 import {
   createSnapshot,
   exportProject,
-  projectExportDisplayed,
-  projectExportNotDisplayed,
   gapiClientReady,
   gapiClientUnavailable,
+  projectExportDisplayed,
+  projectExportNotDisplayed,
 } from './clients';
 
 import {
+  projectCompilationFailed,
+  projectCompiled,
+  refreshPreview,
+} from './compiledProjects';
+import {
+  clearConsoleEntries,
+  consoleErrorProduced,
+  consoleInputChanged,
+  consoleLogBatchProduced,
+  consoleValueProduced,
+  evaluateConsoleEntry,
+  nextConsoleHistory,
+  previousConsoleHistory,
+} from './console';
+import {addRuntimeError} from './errors';
+import {
+  archiveProject,
   beautifyProjectSource,
-  createProject,
   changeCurrentProject,
-  toggleLibrary,
+  createProject,
   hideComponent,
-  unhideComponent,
-  toggleComponent,
-  updateProjectSource,
-  updateProjectInstructions,
   projectSuccessfullySaved,
-  archiveProject,
   saveProject,
+  toggleComponent,
+  toggleLibrary,
+  unhideComponent,
+  updateProjectInstructions,
+  updateProjectSource,
 } from './projects';
 
+import {updateResizableFlex} from './resizableFlex';
 import {
-  focusLine,
+  cancelEditingInstructions,
+  closeAssignmentCreator,
+  closeLoginPrompt,
+  closeTopBarMenu,
+  coursesFullyLoaded,
+  coursesLoaded,
   editorFocusedRequestedLine,
-  startDragColumnDivider,
-  stopDragColumnDivider,
+  focusLine,
+  hideSaveIndicator,
   notificationTriggered,
-  userDismissedNotification,
-  updateNotificationMetadata,
+  openAssignmentCreator,
+  openLoginPrompt,
   popOutProject,
-  toggleEditorTextSize,
-  toggleTopBarMenu,
-  closeTopBarMenu,
-  startEditingInstructions,
-  cancelEditingInstructions,
   showSaveIndicator,
-  hideSaveIndicator,
-  openAssignmentCreator,
-  closeAssignmentCreator,
-  coursesLoaded,
-  coursesFullyLoaded,
+  startDragColumnDivider,
+  startEditingInstructions,
+  stopDragColumnDivider,
   toggleArchivedView,
-  openLoginPrompt,
-  closeLoginPrompt,
+  toggleEditorTextSize,
+  toggleTopBarMenu,
+  updateNotificationMetadata,
+  userDismissedNotification,
 } from './ui';
 
-import {addRuntimeError} from './errors';
-
 import {
   dismissAccountMigration,
   linkGithubIdentity,
-  unlinkGithubIdentity,
   logIn,
   logOut,
   startAccountMigration,
+  unlinkGithubIdentity,
   userAuthenticated,
   userLoggedOut,
 } from './user';
 
-import {
-  projectCompiled,
-  projectCompilationFailed,
-  refreshPreview,
-} from './compiledProjects';
-
-import {
-  clearConsoleEntries,
-  consoleErrorProduced,
-  consoleInputChanged,
-  consoleLogBatchProduced,
-  consoleValueProduced,
-  evaluateConsoleEntry,
-  nextConsoleHistory,
-  previousConsoleHistory,
-} from './console';
-
-import {updateResizableFlex} from './resizableFlex';
-
 export {
   beautifyProjectSource,
   clearConsoleEntries,

src/application.js

@@ -7,8 +7,8 @@ import './init/DOMParserShim';
 import React from 'react';
 import ReactDOM from 'react-dom';
 
-import init from './init';
 import Application from './components/Application';
+import init from './init';
 
 const {store} = init();
 

src/clients/firebase.js

@@ -1,25 +1,25 @@
+import * as firebase from 'firebase/app'; // eslint-disable-line import/no-namespace
 import Cookies from 'js-cookie';
 import get from 'lodash-es/get';
 import isEmpty from 'lodash-es/isEmpty';
 import isNil from 'lodash-es/isNil';
 import isNull from 'lodash-es/isNull';
 import omit from 'lodash-es/omit';
+import once from 'lodash-es/once';
 import values from 'lodash-es/values';
 import uuid from 'uuid/v4';
-import once from 'lodash-es/once';
-import * as firebase from 'firebase/app'; // eslint-disable-line import/no-namespace
 import 'firebase/analytics';
 import 'firebase/auth';
 import 'firebase/performance';
 
-import {bugsnagClient} from '../util/bugsnag';
 import config from '../config';
-import retryingFailedImports from '../util/retryingFailedImports';
 import {
   getGapiSync,
-  loadAndConfigureGapi,
   SCOPES as GOOGLE_SCOPES,
+  loadAndConfigureGapi,
 } from '../services/gapi';
+import {bugsnagClient} from '../util/bugsnag';
+import retryingFailedImports from '../util/retryingFailedImports';
 
 const GITHUB_SCOPES = ['gist', 'public_repo', 'read:user', 'user:email'];
 const VALID_SESSION_UID_COOKIE = 'firebaseAuth.validSessionUid';

src/clients/github.js

@@ -2,10 +2,10 @@ import isEmpty from 'lodash-es/isEmpty';
 import isNull from 'lodash-es/isNull';
 import trim from 'lodash-es/trim';
 
-import retryingFailedImports from '../util/retryingFailedImports';
-import performWithRetries from '../util/performWithRetries';
 import compileProject from '../util/compileProject';
 import ExtendableError from '../util/ExtendableError';
+import performWithRetries from '../util/performWithRetries';
+import retryingFailedImports from '../util/retryingFailedImports';
 
 const COMMIT_MESSAGE = 'Created using Popcode: https://popcode.org';
 const MASTER = 'master';