Distinguish between missing semicolon and extra tokens #146
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This stylesheet:
Yields an “extra tokens after value” error from PrettyCSS. This is
what we’d expect, since there is an extra
1pxat the end of the value,which is not a valid way to write
padding.However, this will generate the same error:
Since CSS is insensitive to newlines, the
marginon the second lineappears to be a continuation of the value for
paddingon the firstline.
We can heuristically identify situations where the “extra tokens after
value” error is the result of a missing semicolon:
its line
So, we now get good error messages for each of these situations: