Skip to content

Conversation

@melodyogonna
Copy link
Contributor

Description

This continues the documentation for the new Github integration powered by Ocean, these are examples for teams, users, issues, and folders.

Updated docs pages

Please also include the path for the updated docs

  • Examples (/build-your-software-catalog/sync-data-to-catalog/git/github-ocean/examples/)

@melodyogonna melodyogonna marked this pull request as ready for review July 15, 2025 09:55
@melodyogonna melodyogonna force-pushed the PORT-14552-github-team-user-folder-docs branch from 249c998 to 6469908 Compare July 17, 2025 12:56
Base automatically changed from PORT-14552-document-github-ocean to main July 31, 2025 08:28
@melodyogonna melodyogonna force-pushed the PORT-14552-github-team-user-folder-docs branch from c1a425b to 6b97dee Compare August 12, 2025 07:41
@github-actions github-actions bot deleted a comment from claude bot Aug 12, 2025
@github-actions github-actions bot deleted a comment from claude bot Aug 12, 2025
@github-actions github-actions bot deleted a comment from claude bot Aug 18, 2025
@github-actions github-actions bot deleted a comment from claude bot Aug 18, 2025
@github-actions github-actions bot deleted a comment from claude bot Aug 18, 2025
@github-actions github-actions bot deleted a comment from claude bot Aug 18, 2025
@github-actions github-actions bot deleted a comment from claude bot Aug 18, 2025
@github-actions github-actions bot deleted a comment from claude bot Aug 18, 2025
@claude
Copy link

claude bot commented Aug 18, 2025

Claude finished @melodyogonna's task —— View job


PR Review: GitHub Ocean examples for team, user, issues, and folder

Todo List:

  • Read CONTRIBUTING.md guidelines
  • Review main examples.md changes
  • Review new example files for issues
  • Review new example files for teams and users
  • Review new example files for folders/monorepo
  • Review new example files for repository collaborators
  • Check existing file modifications for consistency
  • Address sivanel97's review comments
  • Provide final assessment and recommendations

Review Summary

This PR successfully adds comprehensive documentation for GitHub Ocean examples covering teams, users, issues, and folders. The changes are well-structured and follow most of the documentation guidelines established in CONTRIBUTING.md.

✅ Strengths

  1. Comprehensive Coverage: The PR adds examples for several important GitHub resources (issues, teams, users, folders, collaborators)
  2. Consistent Structure: New examples follow the established pattern of blueprint + config files
  3. Proper Code Formatting: All code blocks use showLineNumbers as required
  4. Collapsible Sections: Proper use of <details> and <summary> elements for better organization
  5. Clear Relationships: Well-defined relations between entities (e.g., issues to repositories, teams to members)

⚠️ Issues Found

Critical Issues

  1. Inconsistent Summary Formatting - sivanel97's review comments are valid. Several files have inconsistent summary text formats:

    • Some use "blueprint" vs "Blueprint" inconsistencies
    • Missing "click to expand" text in some summaries
    • Inconsistent capitalization patterns
  2. Formatting Inconsistencies in examples.md:

    • docs/build-your-software-catalog/sync-data-to-catalog/git/github-ocean/examples/examples.md:129 - Line break should be "In the following example you will ingest..." for consistency
    • docs/build-your-software-catalog/sync-data-to-catalog/git/github-ocean/examples/examples.md:191 - Should be "The following shows how you can map..." for consistency
  3. YAML vs YML Extension Inconsistency:

    • docs/build-your-software-catalog/sync-data-to-catalog/git/github-ocean/examples/example-team-members/_github_team_member_port_app_config.mdx:2 shows "port-app-config.yaml" but should be "port-app-config.yml" for consistency

Minor Issues

  1. Title Casing Issues:

    • docs/build-your-software-catalog/sync-data-to-catalog/git/github-ocean/examples/example-repository-admins/_github_exporter_example_users_blueprint.mdx:7 - Title should be "User" not "user" (capitalize first letter)
  2. Missing Content in Monorepo Config:

    • The monorepo example config file appears to be incomplete - it doesn't include the full resources: wrapper structure like other examples

🔧 Specific Fixes Needed

Based on sivanel97's review comments, the following files need summary formatting fixes:

  1. example-issue/_git_exporter_example_issue_blueprint.mdx - Update to: <summary><b>Issue blueprint (click to expand)</b></summary>
  2. example-issue/_github_exporter_example_issue_port_app_config.mdx - Update to: <summary><b>Port port-app-config.yml (click to expand)</b></summary>
  3. example-monorepo/_github_exporter_example_monorepo_port_app_config.mdx - Update to: <summary><b>Port port-app-config.yml (click to expand)</b></summary>
  4. All other files mentioned in sivanel97's comments need similar fixes

📋 Recommendations

  1. Apply sivanel97's Suggestions: All the formatting suggestions are valid and should be implemented to ensure consistency
  2. Standardize Summary Format: Use the pattern <summary><b>[Entity type] blueprint (click to expand)</b></summary> or <summary><b>Port port-app-config.yml (click to expand)</b></summary>
  3. Review Title Casing: Ensure all blueprint titles follow the capitalization guidelines
  4. Complete Monorepo Example: The monorepo config appears incomplete - verify it includes all necessary configuration structure

Overall Assessment

Rating: Approve with Changes Required

The PR provides valuable documentation additions that will help users understand GitHub Ocean integration capabilities. The content is technically accurate and well-organized. However, the formatting inconsistencies identified by sivanel97 should be addressed before merging to maintain documentation quality standards.

The changes align well with Port's documentation style and provide practical, usable examples for developers.


@melodyogonna melodyogonna requested a review from sivanel97 August 20, 2025 12:34
Copy link
Member

@matan84 matan84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a few comments

@melodyogonna melodyogonna requested a review from matan84 August 21, 2025 11:11
Copy link
Member

@matan84 matan84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sivanel97 sivanel97 merged commit 1098f12 into main Aug 24, 2025
1 check passed
@sivanel97 sivanel97 deleted the PORT-14552-github-team-user-folder-docs branch August 24, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants