Skip to content

Conversation

@kodjomiles
Copy link
Collaborator

Description

Added a documentation that guides the user on how to map prs to services in a monorepo

Added docs pages

Please also include the path for the added docs

-Map PR's to services in a monorepo (/guides/all/map-prs-to-services-in-monorepo)

…ps to create and update blueprints, including the new `file_change_url` property. Update automation configurations for fetching and updating PRs with file changes.
@kodjomiles kodjomiles requested a review from hadar-co August 12, 2025 09:19
@kodjomiles kodjomiles self-assigned this Aug 12, 2025
@kodjomiles kodjomiles added the documentation Improvements or additions to documentation label Aug 12, 2025
@notion-workspace
Copy link

@aws-amplify-eu-west-1
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-2666.d2ngvl90zqbob8.amplifyapp.com

…w `services` section in the blueprint configuration, including detailed steps for integration.
@github-actions github-actions bot deleted a comment from claude bot Aug 14, 2025
@github-actions github-actions bot deleted a comment from claude bot Aug 14, 2025
…ing PRs to services in a monorepo for clarity.
…thub.com:port-labs/port-docs into PORTN-3235-docs-map-prs-to-service-in-a-monorepo
@github-actions github-actions bot deleted a comment from claude bot Aug 14, 2025
@claude
Copy link

claude bot commented Aug 14, 2025

Claude finished @kodjomiles's task —— View job


PR Review in Progress

Reviewing PR #2666: "PORTN-3235 Map prs to service in a monorepo guide"

Todo List:

  • Read CONTRIBUTING.md to understand review guidelines
  • Read CLAUDE.md for repo-specific instructions (file not found)
  • Review new guide: docs/guides/all/map-prs-to-services-in-monorepo.md
  • Review changes to: src/components/guides-section/consts.js
  • Check for documentation standards compliance
  • Provide comprehensive review feedback

Review Results

This PR adds a comprehensive guide for mapping GitHub pull requests to services in a monorepo. Here's my detailed review:

Strengths

  1. Well-structured content: The guide follows a logical flow from prerequisites through implementation to testing
  2. Comprehensive coverage: Covers blueprint creation, data sources, automations, and testing
  3. Proper integration: Correctly added to the guides section with appropriate tags and metadata
  4. Clear step-by-step instructions: Each section provides detailed, actionable steps
  5. Good use of expandable sections: Complex JSON configurations are properly collapsed for readability

⚠️ Issues Found

Documentation Standards Issues

  1. Header capitalization inconsistency (map-prs-to-services-in-monorepo.md:6)

    • Current: # Map PR's to services in a monorepo
    • Should be: # Map PRs to services in a monorepo
    • Per CONTRIBUTING.md: Headers should have capital letter only for first word, and "PR's" should be "PRs"
  2. Inconsistent apostrophe usage

    • Title uses "PR's" but should be "PRs" (possessive not needed)
    • This affects both the markdown file and the consts.js entry
  3. Missing accessibility considerations (map-prs-to-services-in-monorepo.md:86, 179)

    • Code blocks lack alt text descriptions for screen readers
    • Consider adding brief descriptions of what each JSON schema represents
  4. Link format concerns (map-prs-to-services-in-monorepo.md:14, 17)

    • Links appear to use full paths correctly ✅
    • Internal links properly formatted ✅

Technical Content Issues

  1. Hardcoded values (map-prs-to-services-in-monorepo.md:238, 333)

    • Line 238: repos: - platform should provide guidance on customizing this
    • Line 333: YOUR_GITHUB_TOKEN needs clearer instructions on token creation
  2. Incomplete error handling (map-prs-to-services-in-monorepo.md:392)

    • The automation mapping could benefit from error handling examples
    • No troubleshooting section for common issues
  3. Missing prerequisites detail (map-prs-to-services-in-monorepo.md:16)

    • "Services organized in directories with a service.yml file" needs more specificity
    • Should provide example directory structure

Code Quality Issues

  1. Proper integration in consts.js
    • Correctly added at line 1346-1351
    • Proper tags: ["SDLC", "GitHub", "Automations"]
    • Appropriate logos: ["GitHub"]
    • Correct link path

📝 Recommendations

  1. Fix title capitalization in both markdown file and consts.js
  2. Add example directory structure in prerequisites
  3. Expand troubleshooting section with common issues
  4. Provide clearer token setup instructions
  5. Add brief descriptions for complex JSON blocks
  6. Consider adding screenshots per CONTRIBUTING.md guidelines for guides

🎯 Checklist Status

Based on CONTRIBUTING.md document review checklist:

  • Content is accurate and up-to-date
  • ❌ Spelling and grammar need minor fixes (apostrophe usage)
  • ❌ Formatting needs header capitalization fix
  • Links work correctly
  • Code examples follow best practices
  • Tone is consistent with Port's documentation style
  • Content is organized logically
  • ❌ Some technical terms could use more explanation
  • No marketing language present

🏁 Overall Assessment

This is a solid and valuable addition to the documentation with comprehensive coverage of a complex automation workflow. The content is technically sound and well-structured. The main issues are minor formatting inconsistencies that should be addressed before merging.

Recommendation: ✅ Approve after addressing formatting issues - particularly the title capitalization and apostrophe usage.


kodjomiles and others added 3 commits August 20, 2025 10:18
…fying terminology and enhancing instructions. Change title to remove apostrophe and ensure consistency in referring to sub-components as 'services'.
kodjomiles and others added 2 commits August 20, 2025 15:18
…ntation, clarifying the automatic creation of blueprints after installing Port's GitHub App and removing outdated steps for manual blueprint creation.
@hadar-co hadar-co merged commit 8cdf28d into main Aug 20, 2025
2 checks passed
@hadar-co hadar-co deleted the PORTN-3235-docs-map-prs-to-service-in-a-monorepo branch August 20, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants