Skip to content

Modify Comdirect PDF-Importer to support format changes #2129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 13, 2021
Merged

Modify Comdirect PDF-Importer to support format changes #2129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb82789
Modify Comdirect PDF-Importer to support format changes
Nirus2000 Mar 5, 2021
03b7626
Modify Comdirect PDF-Importer to support format changes
Nirus2000 Mar 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 45 additions & 0 deletions ...ests/src/name/abuchen/portfolio/datatransfer/pdf/comdirect/ComdirectPDFExtractorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,6 +491,43 @@ public void testWertpapierKauf11WithSecurityInUSD()
assertThat(grossValue.getForex(), is(Money.of(CurrencyUnit.USD, Values.Amount.factorize(4768.00))));
}

@Test
public void testWertpapierKauf12()
{
ComdirectPDFExtractor extractor = new ComdirectPDFExtractor(new Client());

List<Exception> errors = new ArrayList<>();

List<Item> results = extractor.extract(
PDFInputFile.loadTestCase(getClass(), "comdirectWertpapierabrechnung_Kauf12.txt"), errors);

assertThat(errors, empty());
assertThat(results.size(), is(2));

Optional<Item> item;

// security
item = results.stream().filter(i -> i instanceof SecurityItem).findFirst();
Security security = ((SecurityItem) item.orElseThrow(IllegalArgumentException::new)).getSecurity();
assertThat(security.getName(), is("BlackRock TCP Capital Corp. Registered Shares DL -,001"));
assertThat(security.getIsin(), is("US09259E1082"));
assertThat(security.getWkn(), is("A2N4AB"));

item = results.stream().filter(i -> i instanceof BuySellEntryItem).findFirst();
BuySellEntry entry = (BuySellEntry) item.orElseThrow(IllegalArgumentException::new).getSubject();

assertThat(entry.getPortfolioTransaction().getType(), is(PortfolioTransaction.Type.BUY));
assertThat(entry.getAccountTransaction().getType(), is(AccountTransaction.Type.BUY));

assertThat(entry.getPortfolioTransaction().getAmount(), is(Values.Amount.factorize(1430.30)));
assertThat(entry.getPortfolioTransaction().getDateTime(), is(LocalDateTime.parse("2020-12-28T16:50")));
assertThat(entry.getPortfolioTransaction().getUnitSum(Unit.Type.FEE),
is(Money.of("EUR", Values.Amount.factorize(12.80))));
assertThat(entry.getPortfolioTransaction().getUnitSum(Unit.Type.TAX),
is(Money.of("EUR", Values.Amount.factorize(0.00))));
assertThat(entry.getPortfolioTransaction().getShares(), is(Values.Share.factorize(150)));
}

@Test
public void testWertpapierVerkauf()
{
Expand Down Expand Up @@ -672,6 +709,14 @@ public void testWertpapierVerkauf5()
assertThat(txP.getUnitSum(Unit.Type.FEE),
is(Money.of("EUR", Values.Amount.factorize(12.90 + 13.90 / 1.222500))));
assertThat(txP.getShares(), is(Values.Share.factorize(25)));

// check tax-refund transaction
Item itemTaxReturn = results.stream().filter(i -> i instanceof TransactionItem).collect(Collectors.toList())
.get(0);
AccountTransaction entryTaxReturn = (AccountTransaction) itemTaxReturn.getSubject();
assertThat(entryTaxReturn.getType(), is(AccountTransaction.Type.TAX_REFUND));
assertThat(entryTaxReturn.getMonetaryAmount(), is(Money.of(CurrencyUnit.EUR, Values.Amount.factorize(10.84))));
assertThat(entryTaxReturn.getDateTime(), is(LocalDateTime.parse("2020-12-15T00:00")));
}

@Test
Expand Down
Loading