Make protocol assertions macros #950
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that downstream assertions can see supplied code
Contributor
Author
|
Before: Screen.Recording.2025-10-28.at.14.42.27.movAfter: Screen.Recording.2025-10-28.at.14.41.16.mov |
Contributor
Author
|
I'm going to use another approach recommended by @DavisVaughan: a |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that downstream assertions can expose file and line location in the test files, instead of
dummy_frontend.rs. This way we're able to click on the reported locations to jump to the relevant test failure.