Skip to content

Conversation

@cgraham-rs
Copy link
Contributor

@cgraham-rs cgraham-rs commented Jul 31, 2025

This PR adds more detailed instructions and images on how to setup the required env var.

image

Fixes: https://github.com/posit-dev/connect/issues/32797

Currently deployed on our private team Connect server here: https://dogfood.team.pct.posit.it/connect/#/apps/1d97c1ff-e56c-4074-906f-cb3557685b75/7281

Copy link
Collaborator

@toph-allen toph-allen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good! Just a few minor nitpicks or suggestions, but looks good to merge!

Another super-minor nit: Some of the lines end in periods, one ends in a colon, and some have no punctuation at the end, and you could harmonize them slightly. This is mostly just a pet peeve of mine, not something I think is critical! 😅

# f'<img src="images/add-variable.png" alt="Adding environment variable" style="max-width: 80%; margin: 10px 0; border: 1px solid #ddd;"><br>'
f"{one_tab}• Click <b>Add Variable</b> to save it<br><br>"

f"<b>Step 3:</b> Click <b>Refresh Report</b> in the top right to continue.<br>"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you could say something like "to run a health check for the content using the new variable" to make it more explicit what action will take place, i.e. rendering the report is the health check? Not a requirement tho.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think being explicit makes sense. Note that I changed the wording slightly from your suggestion.
image

@cgraham-rs cgraham-rs force-pushed the cgraham/chm-document-guid branch from 4225864 to bc0a17c Compare August 5, 2025 14:42
@cgraham-rs cgraham-rs merged commit 7baa79d into main Aug 5, 2025
16 checks passed
@cgraham-rs cgraham-rs deleted the cgraham/chm-document-guid branch August 5, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants