-
Notifications
You must be signed in to change notification settings - Fork 4
who deploys most often (table edition) #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The loading time isn't super long, but it is long enough that it's perceivable and might lead someone to move on. Would it be possible (and is it advisable) to use something like https://shiny.posit.co/r/articles/improve/caching/ to improve loading performance? We can kick this to a different issue if you would like, but thinking about the experience we want for demos like this, if pulling the raw data takes this long, we want to do something to make it nicer for the people who will give us feedback. |
|
@jonkeane I think the experience of loading the app would also be improved if there was a "loading data" dialog, as in the other demo dashboards I built. I was trying to keep this one as minimal as possible, though. I'll look into using Shiny caching for this. |
|
@jonkeane I've made some updates based on your feedback.
I also deployed the content to connect.posit.it: https://connect.posit.it/who-deploys-most-often/ This approach to caching is so much better than the hacky |
YAS this is great. The date hash key is a great idea + gets us the kind of behavior we want with the least moving pieces. If we do keep this type of caching around in later editions we might also add a button to let someone refresh the cache live, but defaulting it to the date is 💯 the right move. |
jonkeane
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! The responsiveness + clarity is really nice
|
@jonkeane I was thinking the exact same thing about having a button to force refresh the cache. :) |
|
Minor comment that can be addressed in subsequent PRs since this one is already closed. The table headers names ( |
Prototype metrics extension.
Loads data from Connect to display the following:
No reactivity or filters or anything fancy yet, just loading and processing the data.
Currently "number of deployments" uses fake data because the API does not support administrators loading bundle metadata for each content item yet.
The app is deployed on Dogfood and connect.posit.it: