Remove old renderer#81
Merged
rich-iannone merged 6 commits intoposit-dev:mainfrom Apr 13, 2026
Merged
Conversation
The three-layer renderer hierarchy (Renderer → MdRenderer → bridge Renderer → assets Renderer) existed only to satisfy the old class structure. The new _render/ subpackage only uses the renderer as a config holder (3 properties).
RenderConfig was a pass-through dataclass threaded through every Render object but only consumed in two places. Move its properties to their natural homes: - display_name_format, signature_name_format → RenderDoc fields - header_level, typing_module_paths → Builder attributes - show_signature → already a RenderDoc field (redundant override removed) Delete _render_config.py and remove config from RenderBase.
The "q" prefix was a historical artifact. Rename the private subpackage to the simpler _renderer name, updating all 138 references across source, tests, and configuration.
Merged
Narrow pyright scope to _render subpackage, add proper type aliases (Annotation, DocstringDefinitionType), replace untyped lists/signatures with specific types, and add Stringable protocol for html_table.
Merge branch 'main' into pr/81 to integrate PR posit-dev#81 from has2k1. Conflict resolution in core.py: kept both the PR's new import path (_renderer instead of _qrenderer) and main's _patch_griffe() call for griffe compatibility.
The Builder now filters out 'renderer' and 'style' keys, so this config dict was being silently discarded. Remove it for clarity.
Member
|
@has2k1 sorry again that this took so long to get to. I merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While core modular functions introduced by qrenderer replaced the original renderer, they were applied through a subclass of the old renderer. This PR makes qrenderer the first-class renderer, and completes the transition from the original renderer.