Add busy/idle status reporting at the runtime level #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesm
pushed a commit
that referenced
this pull request
Mar 28, 2024
Merge pull request #114 from posit-dev/magic-viewer -------------------- Commit message for posit-dev/positron-python@6bab2da: add all requirements from positron_jedilsp -------------------- Commit message for posit-dev/positron-python@7f92125: add pygls to build requirements -------------------- Commit message for posit-dev/positron-python@38571ec: Merge branch 'main' into magic-viewer -------------------- Commit message for posit-dev/positron-python@c01c112: add build requirements -------------------- Commit message for posit-dev/positron-python@41122f6: linting -------------------- Commit message for posit-dev/positron-python@2ae5dd5: add beginning of tests These tests run an ipython kernel with a magic registered. They will check to see if the %view magic exists and not error on run for pandas dataframes and expressions. It will also check that a TypeError is thrown if an incorrect type is used. -------------------- Commit message for posit-dev/positron-python@934b395: changes from suggestions -------------------- Commit message for posit-dev/positron-python@194754a: Apply suggestions from code review Co-authored-by: Wasim Lorgat <mwlorgat@gmail.com> -------------------- Commit message for posit-dev/positron-python@495b2b3: linting -------------------- Commit message for posit-dev/positron-python@067e02d: add ipython ViewerMagic Create a linemagic that ingests user input and opens up in DataViewer tab Authored-by: Isabel Zimmerman <isabel.zimmerman@rstudio.com> Signed-off-by: Isabel Zimmerman <isabel.zimmerman@rstudio.com>
wesm
pushed a commit
that referenced
this pull request
Mar 28, 2024
Merge pull request #114 from posit-dev/magic-viewer -------------------- Commit message for posit-dev/positron-python@6bab2da: add all requirements from positron_jedilsp -------------------- Commit message for posit-dev/positron-python@7f92125: add pygls to build requirements -------------------- Commit message for posit-dev/positron-python@38571ec: Merge branch 'main' into magic-viewer -------------------- Commit message for posit-dev/positron-python@c01c112: add build requirements -------------------- Commit message for posit-dev/positron-python@41122f6: linting -------------------- Commit message for posit-dev/positron-python@2ae5dd5: add beginning of tests These tests run an ipython kernel with a magic registered. They will check to see if the %view magic exists and not error on run for pandas dataframes and expressions. It will also check that a TypeError is thrown if an incorrect type is used. -------------------- Commit message for posit-dev/positron-python@934b395: changes from suggestions -------------------- Commit message for posit-dev/positron-python@194754a: Apply suggestions from code review Co-authored-by: Wasim Lorgat <mwlorgat@gmail.com> -------------------- Commit message for posit-dev/positron-python@495b2b3: linting -------------------- Commit message for posit-dev/positron-python@067e02d: add ipython ViewerMagic Create a linemagic that ingests user input and opens up in DataViewer tab Authored-by: Isabel Zimmerman <isabel.zimmerman@rstudio.com> Signed-off-by: Isabel Zimmerman <isabel.zimmerman@rstudio.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change hoists the busy/idle state from the status message layer up to the runtime state layer for all runtimes that sit on top of the Jupyter Adapter (which is currently all of them except for Zed, which already has emitters).