Skip to content

Conversation

@isabelizimm
Copy link
Contributor

@isabelizimm isabelizimm commented Mar 10, 2025

Release notes for v2025.2.0.

Not too much here that will affect us. The primary work i:

  • integration with the Python environments extension
  • updates to Native REPL
  • telemetry cleanup

Nearly all of the changed lines are from the package-lock.json.

Release Notes

Maintenance #6581

New Features

  • N/A

Bug Fixes

  • N/A

QA Notes

@github-actions
Copy link

github-actions bot commented Mar 10, 2025

E2E Tests 🚀
This PR will run tests tagged with: @:critical

readme  valid tags

@isabelizimm
Copy link
Contributor Author

A LOT of this PR is updates to extensions/positron-python/package-lock.json. As per our upstream merge instructions, we've always removed this file since we didn't use npm at the time. Now we do. What do people think of trying to match it to upstream?

@isabelizimm isabelizimm marked this pull request as ready for review March 11, 2025 19:52
Copy link
Contributor

@seeM seeM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things seem to work as expected locally! I pushed 1ed0ddb to disable the Jupyter interactive window on shift+enter, not sure when exactly that crept in though. Should we run the full test suite before merging?

--hash=sha256:eaa912e0b11848c4d9279a93d7e2783df352b082f40111e078388701fd479e53 \
--hash=sha256:f35cfccb065fff93529d2afb4a2e89e363fe63ca1e4a5da22b603a85833c2649 \
--hash=sha256:fc0ed7fe2231a444fc219b9c42d0376e0a9a1a72f16c5cfa0f68d19f1a0663e8
psutil==7.0.0 \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a major upgrade and psutil includes platform-specific binaries, we should double-check that this doesn't cause any platform-specific build issues after we've merged.

if selection[-2] == "}" or selection[-2] == "]":
source = source[:-1]
# If the selection contains trailing return dictionary, insert newline to trigger execute.
if check_end_with_return_dict(selection):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use this code so should double-check how this affects Cmd+Enter for lines like return {}. I doubt we've covered that in e2e tests.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checked this out 👀 it looks like it will insert a newline in the script and in the console, but will still execute as expected.

Screen.Recording.2025-03-12.at.12.43.47.PM.mov

}
}

export interface JupyterPythonEnvironmentApi {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably worth keeping an eye on what this is solving and whether we can/want to use it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's the upstream PR that added it! microsoft/vscode-python#24771

Looks like it was originally added to have one single way to get the environment for Python scripts/notebooks/etc (and fix a bug where the first selection of a kernel for a Jupyter notebook didn't fire a change event).

Copy link
Contributor

@austin3dickey austin3dickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@isabelizimm
Copy link
Contributor Author

Awesome, thanks for that update! I kicked off a full run of e2e tests and can merge this once that is certified green ✅

@isabelizimm isabelizimm merged commit 33c515d into main Mar 12, 2025
34 checks passed
@isabelizimm isabelizimm deleted the vscode-python-v2025.2 branch March 12, 2025 18:19
@github-actions github-actions bot locked and limited conversation to collaborators Mar 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants