Skip to content

HTMLTextDocument() now preserves the order of serialized dependencies #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 18, 2024
Merged

HTMLTextDocument() now preserves the order of serialized dependencies #95

merged 3 commits into from
Sep 18, 2024

Conversation

@cpsievert
Copy link
Collaborator

@cpsievert cpsievert commented Sep 18, 2024 •
edited
Loading

Closes #94

Note:

  1. This PR is currently pointing at Start new version; get pyright passing #96 just so that typing checks are passing
  2. 4c548bc highlights the currently existing issue -- the order of dependencies extracted and returned by HTMLTextDocument() is non-deterministic
  3. 32de2cb fixes the issue by avoiding list(set(x)) to dedupe dependencies.

@cpsievert cpsievert marked this pull request as draft September 18, 2024 01:19
@cpsievert cpsievert force-pushed the fix/HTMLTextDocument-dep-ordering branch 2 times, most recently from ffee28e to 67b203e Compare September 18, 2024 14:19
@cpsievert cpsievert changed the base branch from main to bump-version September 18, 2024 14:19
@cpsievert cpsievert marked this pull request as ready for review September 18, 2024 14:24
@cpsievert cpsievert requested a review from wch September 18, 2024 14:25
Base automatically changed from bump-version to main September 18, 2024 18:31
@cpsievert cpsievert force-pushed the fix/HTMLTextDocument-dep-ordering branch from b515de1 to 6f808cb Compare September 18, 2024 18:39
@cpsievert cpsievert requested a review from schloerke September 18, 2024 18:43
@cpsievert cpsievert merged commit 1857415 into main Sep 18, 2024
16 checks passed
@cpsievert cpsievert deleted the fix/HTMLTextDocument-dep-ordering branch September 18, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@schloerke schloerke schloerke approved these changes

@wch wch Awaiting requested review from wch

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

HTMLTextDocument() doesn't necessarily preserve the order of serialized dependencies

2 participants

@cpsievert @schloerke