fix(pkg-py): fix/disallow setting of initialization values post-initialization #108
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #101.
In that PR, I added the following methods to set initial values after initialization:
set_system_promptset_data_sourceset_clientProblem is, calling these methods after
.server()is too late since they're effectively setting input values for the Shiny server module. This makes them effectively useless with Express.Since these methods weren't all that useful to begin with, this PR removes them. It will, however, keep the ability to mutate the session-specific
.client(where you can also change the.system_prompt). Also, by setting up a fork of the client earlier, we can drop the separate.system_promptstate, and make the per-session forks more efficient.