feat: sidebar() is now fillable by default
#152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
PS. @gadenbuie just FYI, I'm still seeing a lack of scrolling to the bottom as responses stream in with posit-dev/shinychat@cf9d098 installed |
gadenbuie
reviewed
Dec 9, 2025
| bslib::sidebar( | ||
| width = width, | ||
| height = height, | ||
| fillable = fillable, |
Contributor
There was a problem hiding this comment.
Does this mean we need to release bslib in order to release querychat? Or can we get away with releasing querychat first?
Contributor
Author
There was a problem hiding this comment.
Oh, good point -- I don't think we'd have to make it a strict requirement since it's a progressive enhancement, but I also wouldn't be opposed to getting another release out
Contributor
There was a problem hiding this comment.
Cool -- I want to get bslib out by end of year but I'd rather push querychat out first if we can.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change: the chat input appears immediately below the greeting.
After this change: the chat input is anchored at the bottom of the viewport.