-
Notifications
You must be signed in to change notification settings - Fork 20
feat(init): Replace create_chat_func
with client
#60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the R `querychat.client` option and the `QUERYCHAT_CLIENT` environment variable.
In case `system_prompt` is a required argument
cpsievert
reviewed
Aug 13, 2025
cpsievert
reviewed
Aug 13, 2025
cpsievert
reviewed
Aug 13, 2025
cpsievert
reviewed
Aug 13, 2025
cpsievert
reviewed
Aug 13, 2025
cpsievert
reviewed
Aug 13, 2025
Co-authored-by: Carson Sievert <cpsievert1@gmail.com>
cpsievert
reviewed
Aug 13, 2025
cpsievert
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #58
Python
querychat.init()
now accepts aclient
argument, replacing the previouscreate_chat_callback
argument.The
client
can be:chatlas.Chat
object,chatlas.Chat
object,"openai/gpt-4.1"
, to be passed tochatlas.ChatAuto()
.If
client
is not provided, querychat will use theQUERYCHAT_CLIENT
environment variable, which should be a provider-model string. If the envvar is not set, querychat uses OpenAI with the default model fromchatlas.ChatOpenAI()
.R
querychat_init()
now accepts aclient
, replacing the previouscreate_chat_func
argument.The
client
can be:ellmer::Chat
object,ellmer::Chat
object,"openai/gpt-4.1"
, to be passed toellmer::chat()
.If
client
is not provided, querychat will usequerychat.client
R option, which can be any of the above options,QUERYCHAT_CLIENT
environment variable, which should be a provider-model string,ellmer::chat_openai()
.