Skip to content

Adding server doesn't work with click 7.1.2 #295

@danielbender1989

Description

@danielbender1989

I was trying to add a server with rsconnect add via command line on a system where click 7.1.2 was preinstalled. This resulted in the following error:

agent_1  | [Container] 2022/10/20 08:27:19 Running command rsconnect add --server server --name cap --api-key key 
agent_1  | Detected the following inputs:
agent_1  | Traceback (most recent call last):
agent_1  |   File "/root/.pyenv/versions/3.9.12/bin/rsconnect", line 8, in <module>
agent_1  |     sys.exit(cli())
agent_1  |   File "/root/.pyenv/versions/3.9.12/lib/python3.9/site-packages/click/core.py", line 829, in __call__
agent_1  |     return self.main(*args, **kwargs)
agent_1  |   File "/root/.pyenv/versions/3.9.12/lib/python3.9/site-packages/click/core.py", line 782, in main
agent_1  |     rv = self.invoke(ctx)
agent_1  |   File "/root/.pyenv/versions/3.9.12/lib/python3.9/site-packages/click/core.py", line 1259, in invoke
agent_1  |     return _process_result(sub_ctx.command.invoke(sub_ctx))
agent_1  |   File "/root/.pyenv/versions/3.9.12/lib/python3.9/site-packages/click/core.py", line 1066, in invoke
agent_1  |     return ctx.invoke(self.callback, **ctx.params)
agent_1  |   File "/root/.pyenv/versions/3.9.12/lib/python3.9/site-packages/click/core.py", line 610, in invoke
agent_1  |     return callback(*args, **kwargs)
agent_1  |   File "/root/.pyenv/versions/3.9.12/lib/python3.9/site-packages/rsconnect/main.py", line 157, in wrapper
agent_1  |     return func(*args, **kwargs)
agent_1  |   File "/root/.pyenv/versions/3.9.12/lib/python3.9/site-packages/click/decorators.py", line 21, in new_func
agent_1  |     return f(get_current_context(), *args, **kwargs)
agent_1  |   File "/root/.pyenv/versions/3.9.12/lib/python3.9/site-packages/rsconnect/main.py", line 332, in add
agent_1  |     click.echo("    {}: {}".format(k, ctx.get_parameter_source(k).name))
agent_1  | AttributeError: 'Context' object has no attribute 'get_parameter_source'

According to the release notes of click, detecting parameter sources was only added in version 8.0.0. Therefore, it would make sense to change the requirements to click >= 8.0.0.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions