Skip to content

Conversation

@bcwu
Copy link
Contributor

@bcwu bcwu commented Jun 2, 2023

Intent

This PR removes the server capability check in order to allow Python for Shiny to be deployed with a base Connect license.

The other reason for the functionality removal is that the functionality it is redundant. Connect itself will return the corresponding error messages if the server does not have APIs enabled or if Python is not enabled. Maintaining this check client side check is not only redundant, but actively obstructs server features from being functional without a client side change.

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change

Approach

Automated Tests

Directions for Reviewers

Checklist

  • I have updated CHANGELOG.md to cover notable changes.
  • I have updated all related GitHub issues to reflect their current state.

@bcwu bcwu force-pushed the remove-capability-check branch from 041b030 to 11617c4 Compare June 2, 2023 15:00
@github-actions
Copy link

github-actions bot commented Jun 2, 2023

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
4169 2638 63% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
rsconnect/actions.py 33% 🟢
rsconnect/api.py 66% 🟢
rsconnect/bundle.py 77% 🟢
rsconnect/main.py 54% 🟢
TOTAL 57% 🟢

updated for commit: 11617c4 by action🐍

@kgartland-rstudio
Copy link
Contributor

Validating all "api" content is still undeployable. The only content type that should be deployable is Jupyter notebook.

Testing with Python APIs disabled:
proper error:

This content is not authorized to be deployed on this server (deployment-unauthorized-error)
Error from Connect server: API applications are not permitted by your license.
Error: Task exited with status 65.

Can't deploy

  • flaskapi
  • fastapi
  • dash
  • streamlit
  • bokeh
  • shiny
  • Voila notebook

no error:
Can deploy

  • Jupyter notebook

via Jupyter UI

  • Jupyter notebook

Testing with Python APIs enabled, all Content deploys.

@mmarchetti mmarchetti merged commit d44f0b6 into master Jun 20, 2023
@mmarchetti mmarchetti deleted the remove-capability-check branch June 20, 2023 14:28
tdstein added a commit that referenced this pull request Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants