Skip to content

Commit dd124b3

Browse files
committed
[Issue #113] improve test coverage
1 parent aef926f commit dd124b3

File tree

1 file changed

+12
-18
lines changed

1 file changed

+12
-18
lines changed

tests/merge.py

Lines changed: 12 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -111,17 +111,15 @@ def test_merge_compressed_backups(self):
111111
# Initialize instance and backup directory
112112
node = self.make_simple_node(
113113
base_dir=os.path.join(module_name, fname, 'node'),
114-
initdb_params=["--data-checksums"]
115-
)
114+
initdb_params=["--data-checksums"])
116115

117116
self.init_pb(backup_dir)
118117
self.add_instance(backup_dir, "node", node)
119118
self.set_archiving(backup_dir, "node", node)
120119
node.slow_start()
121120

122121
# Do full compressed backup
123-
self.backup_node(backup_dir, "node", node, options=[
124-
'--compress-algorithm=zlib'])
122+
self.backup_node(backup_dir, "node", node, options=['--compress'])
125123
show_backup = self.show_pb(backup_dir, "node")[0]
126124

127125
self.assertEqual(show_backup["status"], "OK")
@@ -137,16 +135,15 @@ def test_merge_compressed_backups(self):
137135

138136
# Do compressed page backup
139137
self.backup_node(
140-
backup_dir, "node", node, backup_type="page",
141-
options=['--compress-algorithm=zlib'])
138+
backup_dir, "node", node, backup_type="page", options=['--compress'])
142139
show_backup = self.show_pb(backup_dir, "node")[1]
143140
page_id = show_backup["id"]
144141

145142
self.assertEqual(show_backup["status"], "OK")
146143
self.assertEqual(show_backup["backup-mode"], "PAGE")
147144

148145
# Merge all backups
149-
self.merge_backup(backup_dir, "node", page_id)
146+
self.merge_backup(backup_dir, "node", page_id, options=['-j2'])
150147
show_backups = self.show_pb(backup_dir, "node")
151148

152149
self.assertEqual(len(show_backups), 1)
@@ -191,8 +188,7 @@ def test_merge_compressed_backups_1(self):
191188
node.pgbench_init(scale=5)
192189

193190
# Do compressed FULL backup
194-
self.backup_node(backup_dir, "node", node, options=[
195-
'--compress-algorithm=zlib', '--stream'])
191+
self.backup_node(backup_dir, "node", node, options=['--compress', '--stream'])
196192
show_backup = self.show_pb(backup_dir, "node")[0]
197193

198194
self.assertEqual(show_backup["status"], "OK")
@@ -204,17 +200,16 @@ def test_merge_compressed_backups_1(self):
204200

205201
# Do compressed DELTA backup
206202
self.backup_node(
207-
backup_dir, "node", node, backup_type="delta",
208-
options=['--compress-algorithm=zlib', '--stream'])
203+
backup_dir, "node", node,
204+
backup_type="delta", options=['--compress', '--stream'])
209205

210206
# Change data
211207
pgbench = node.pgbench(options=['-T', '20', '-c', '2', '--no-vacuum'])
212208
pgbench.wait()
213209

214210
# Do compressed PAGE backup
215211
self.backup_node(
216-
backup_dir, "node", node, backup_type="page",
217-
options=['--compress-algorithm=zlib'])
212+
backup_dir, "node", node, backup_type="page", options=['--compress'])
218213

219214
pgdata = self.pgdata_content(node.data_dir)
220215

@@ -225,7 +220,7 @@ def test_merge_compressed_backups_1(self):
225220
self.assertEqual(show_backup["backup-mode"], "PAGE")
226221

227222
# Merge all backups
228-
self.merge_backup(backup_dir, "node", page_id)
223+
self.merge_backup(backup_dir, "node", page_id, options=['-j2'])
229224
show_backups = self.show_pb(backup_dir, "node")
230225

231226
self.assertEqual(len(show_backups), 1)
@@ -282,15 +277,14 @@ def test_merge_compressed_and_uncompressed_backups(self):
282277
# Do compressed DELTA backup
283278
self.backup_node(
284279
backup_dir, "node", node, backup_type="delta",
285-
options=['--compress-algorithm=zlib', '--stream'])
280+
options=['--compress', '--stream'])
286281

287282
# Change data
288283
pgbench = node.pgbench(options=['-T', '20', '-c', '2', '--no-vacuum'])
289284
pgbench.wait()
290285

291286
# Do uncompressed PAGE backup
292-
self.backup_node(
293-
backup_dir, "node", node, backup_type="page")
287+
self.backup_node(backup_dir, "node", node, backup_type="page")
294288

295289
pgdata = self.pgdata_content(node.data_dir)
296290

@@ -301,7 +295,7 @@ def test_merge_compressed_and_uncompressed_backups(self):
301295
self.assertEqual(show_backup["backup-mode"], "PAGE")
302296

303297
# Merge all backups
304-
self.merge_backup(backup_dir, "node", page_id)
298+
self.merge_backup(backup_dir, "node", page_id, options=['-j2'])
305299
show_backups = self.show_pb(backup_dir, "node")
306300

307301
self.assertEqual(len(show_backups), 1)

0 commit comments

Comments
 (0)