[PGPRO-11599] Fixed CI crashes at hardcore level.

Tags: rum

Author: Arseny Kositsyn

src/tidbitmap/tidbitmap12.c

@@ -733,9 +733,25 @@ tbm_begin_iterate(TIDBitmap *tbm)
 		while ((page = pagetable_iterate(tbm->pagetable, &i)) != NULL)
 		{
 			if (page->ischunk)
+			{
+				/*
+				 * NOTE: This location is different from the
+				 * original tidbitmap.c. This check is necessary
+				 * to avoid warnings from scan-build.
+				 */
+				Assert(tbm->schunks);
 				tbm->schunks[nchunks++] = page;
+			}
 			else
+			{
+				/*
+				 * NOTE: This location is different from the
+				 * original tidbitmap.c. This check is necessary
+				 * to avoid warnings from scan-build.
+				 */
+				Assert(tbm->spages);
 				tbm->spages[npages++] = page;
+			}
 		}
 		Assert(npages == tbm->npages);
 		Assert(nchunks == tbm->nchunks);

src/tidbitmap/tidbitmap13.c

@@ -733,9 +733,25 @@ tbm_begin_iterate(TIDBitmap *tbm)
 		while ((page = pagetable_iterate(tbm->pagetable, &i)) != NULL)
 		{
 			if (page->ischunk)
+			{
+				/*
+				 * NOTE: This location is different from the
+				 * original tidbitmap.c. This check is necessary
+				 * to avoid warnings from scan-build.
+				 */
+				Assert(tbm->schunks);
 				tbm->schunks[nchunks++] = page;
+			}
 			else
+			{
+				/*
+				 * NOTE: This location is different from the
+				 * original tidbitmap.c. This check is necessary
+				 * to avoid warnings from scan-build.
+				 */
+				Assert(tbm->spages);
 				tbm->spages[npages++] = page;
+			}
 		}
 		Assert(npages == tbm->npages);
 		Assert(nchunks == tbm->nchunks);

src/tidbitmap/tidbitmap14.c

@@ -733,9 +733,25 @@ tbm_begin_iterate(TIDBitmap *tbm)
 		while ((page = pagetable_iterate(tbm->pagetable, &i)) != NULL)
 		{
 			if (page->ischunk)
+			{
+				/*
+				 * NOTE: This location is different from the
+				 * original tidbitmap.c. This check is necessary
+				 * to avoid warnings from scan-build.
+				 */
+				Assert(tbm->schunks);
 				tbm->schunks[nchunks++] = page;
+			}
 			else
+			{
+				/*
+				 * NOTE: This location is different from the
+				 * original tidbitmap.c. This check is necessary
+				 * to avoid warnings from scan-build.
+				 */
+				Assert(tbm->spages);
 				tbm->spages[npages++] = page;
+			}
 		}
 		Assert(npages == tbm->npages);
 		Assert(nchunks == tbm->nchunks);

src/tidbitmap/tidbitmap15.c

@@ -733,9 +733,25 @@ tbm_begin_iterate(TIDBitmap *tbm)
 		while ((page = pagetable_iterate(tbm->pagetable, &i)) != NULL)
 		{
 			if (page->ischunk)
+			{
+				/*
+				 * NOTE: This location is different from the
+				 * original tidbitmap.c. This check is necessary
+				 * to avoid warnings from scan-build.
+				 */
+				Assert(tbm->schunks);
 				tbm->schunks[nchunks++] = page;
+			}
 			else
+			{
+				/*
+				 * NOTE: This location is different from the
+				 * original tidbitmap.c. This check is necessary
+				 * to avoid warnings from scan-build.
+				 */
+				Assert(tbm->spages);
 				tbm->spages[npages++] = page;
+			}
 		}
 		Assert(npages == tbm->npages);
 		Assert(nchunks == tbm->nchunks);

src/tidbitmap/tidbitmap16.c

@@ -733,9 +733,25 @@ tbm_begin_iterate(TIDBitmap *tbm)
 		while ((page = pagetable_iterate(tbm->pagetable, &i)) != NULL)
 		{
 			if (page->ischunk)
+			{
+				/*
+				 * NOTE: This location is different from the
+				 * original tidbitmap.c. This check is necessary
+				 * to avoid warnings from scan-build.
+				 */
+				Assert(tbm->schunks);
 				tbm->schunks[nchunks++] = page;
+			}
 			else
+			{
+				/*
+				 * NOTE: This location is different from the
+				 * original tidbitmap.c. This check is necessary
+				 * to avoid warnings from scan-build.
+				 */
+				Assert(tbm->spages);
 				tbm->spages[npages++] = page;
+			}
 		}
 		Assert(npages == tbm->npages);
 		Assert(nchunks == tbm->nchunks);

src/tidbitmap/tidbitmap17.c

@@ -734,9 +734,25 @@ tbm_begin_iterate(TIDBitmap *tbm)
 		while ((page = pagetable_iterate(tbm->pagetable, &i)) != NULL)
 		{
 			if (page->ischunk)
+			{
+				/*
+				 * NOTE: This location is different from the
+				 * original tidbitmap.c. This check is necessary
+				 * to avoid warnings from scan-build.
+				 */
+				Assert(tbm->schunks);
 				tbm->schunks[nchunks++] = page;
+			}
 			else
+			{
+				/*
+				 * NOTE: This location is different from the
+				 * original tidbitmap.c. This check is necessary
+				 * to avoid warnings from scan-build.
+				 */
+				Assert(tbm->spages);
 				tbm->spages[npages++] = page;
+			}
 		}
 		Assert(npages == tbm->npages);
 		Assert(nchunks == tbm->nchunks);