Skip to content

Conversation

@Scrum
Copy link
Member

@Scrum Scrum commented Apr 10, 2020

Proposed Changes

Describe the big picture of your changes here to communicate to the maintainers
why we should accept this pull request. If it fixes a bug or resolves a feature
request, be sure to link to that issue.

Types of Changes

What types of changes does your code introduce
Put an x in the boxes that apply

  • Bug (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature which changes existing functionality)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask. We're here to
help! This is a reminder of what we are going to look for before merging your
code.

  • I have read the CONTRIBUTING guide
  • Lint and unit tests pass with my changes
  • I have added tests that prove my fix is effective/works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes are merged and published in downstream modules

Further Comments

If this is a large or complex change, kick off the discussion by explaining why
you chose the solution you did and what alternatives you considered, etc...

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 96.939% when pulling 6305424 on milestone-1.3.2 into 054d575 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 96.939% when pulling 6305424 on milestone-1.3.2 into 054d575 on master.

@Scrum Scrum linked an issue Apr 10, 2020 that may be closed by this pull request
@Scrum Scrum merged commit 3e2f583 into master Apr 10, 2020
@Scrum Scrum deleted the milestone-1.3.2 branch April 10, 2020 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

locals can only be JSON string

3 participants