Fix expression ignoring

[cossssmin]

This PR fixes a couple of bugs when ignoring expressions with @{{ }}, as described in #72.

Subsequent ignored expressions now properly work in text nodes:

<p>Here's one @{{ variable }} and here's @{{ another }}.</p>

Result:

<p>Here's one {{ variable }} and here's {{ another }}.</p>

Expressions are now also ignored inside attribute values:

<p data-foo="@{{ bar }}">Lorem ipsum.</p>

Result:

<p data-foo="{{ bar }}">Lorem ipsum.</p>

When merged, this PR will close #72.

[coveralls]

Coverage decreased (-0.05%) to 96.891% when pulling 28ad6ac on cossssmin:fix-ignored into 77aaf56 on posthtml:master.

[Scrum]

@cossssmin Hi, why didn’t you move it to line 154? after all, during the round-trip, regular degeneration with ignore

[cossssmin]

Rushed to push the fix, sorry about that - doing it now... 🤦‍♂️

[Scrum]

Don't worry about it

[cossssmin]

Wait, it won't work there, delimitersSettings isn't yet defined... did you mean line 164?

[Scrum]

Yes, I was a little mistaken, but I would like to endure them or iterate walk, but I see for this they need to be taken out of the osprey for visibility even higher somewhere 13 line

[cossssmin]

delimitersSettings, which the ignoredBefore and ignoredAfter variables (which are the delimiters, {{ and }} by default) use, are not set at that point in time...

[Scrum]

I mean, in line 13, initialize them so that they are accessible from any scoup

[cossssmin]

Not sure what to initialize them to or how you'd like it to work, sorry... I'd appreciate your assistance if you can, feel free to update the PR :)

[Scrum]

@cossssmin its ok ?

[Scrum]

@anikethsaha ping

[anikethsaha]

non-blocking suggestion !

can we have one more example here with usual expression and one ignored expression on same element and also or the same attribute?

like this may

<p data-username="@{{ user.name }}" data-user-id="user-@{{ user.id }}-{{ user.id2 }}">
  And here's a @{{ variable }} that would be undefined.	  Here's one {{ variable }} and here's @{{ another }}.

ignore if already exists.

[cossssmin]

Once @{{ is encountered, the entire string/attribute value is returned as-is.

So this:

Here's one @{{ variable }} and here's some {{ foo }}.

will be output as:

Here's one {{ variable }} and here's some {{ foo }}.

So {{ foo }} will not be evaluated. Which come to think about it, may not be ideal, but I can't see how you'd evaluate {{ foo }}...?

[anikethsaha]

ummm,

can we do like if @{{ comes, it will ignore till first occurrence of }} ? WDYT ?

[cossssmin]

I wonder, maybe changing the regexes here:

posthtml-expressions/lib/index.js

Lines 127 to 138 in 77aaf56

	const delimitersRegexp = new RegExp(`${before}(.+?)${after}`, 'g')
	before = escapeRegexpString(options.unescapeDelimiters[0])
	after = escapeRegexpString(options.unescapeDelimiters[1])
	const unescapeDelimitersRegexp = new RegExp(`${before}(.+?)${after}`, 'g')
	// make array of delimiters
	const delimiters = [
	{ text: options.delimiters, regexp: delimitersRegexp, escape: true },
	{ text: options.unescapeDelimiters, regexp: unescapeDelimitersRegexp, escape: false }
	]

... to match {{ }} or {{{ }}} as long as they don't start with @, would be better instead? So we only match non-ignored delimiters, and then we no longer have to return 'early', so my example above should (theoretically) correctly return:

Here's one {{ variable }} and here's some bar.

(assuming foo: 'bar' in locals).

Thoughts?

[anikethsaha]

to match {{ }} or {{{ }}} as long as they don't start with @, would be better instead?

yeah, I think this should work.

[cossssmin]

Got it working, will push it up in a moment 👍

[anikethsaha]

can you try ^(?! )[^@]{(.+?)}} ?

[anikethsaha]

great 👍

[cossssmin]

So although I got it working, I think I found an issue with how placeholders treats unescaped delimiters.

Basically, since it loops over every item in the settings object it receives, it'll still match {{ var }} inside @{{{ var }}}.

I'll push the fix for regular, escaped delimiters and will open a separate issue for unescaped delimiters.

[anikethsaha]

I'll push the fix for regular, escaped delimiters and will open a separate issue for unescaped delimiters.

cool 👍

[cossssmin]

@cossssmin its ok ?

Yes, sorry, I got what you meant now... 👍

[anikethsaha]

🎉

[Scrum]

@cossssmin publish v1.4.1