Skip to content

Milestone 0.3.2 #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 18, 2018
Merged

Milestone 0.3.2 #28

merged 4 commits into from
Jan 18, 2018

Conversation

Scrum
Copy link
Member

@Scrum Scrum commented Jan 18, 2018

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling cad515c on milestone-0.3.2 into 29944dc on master.

voischev
voischev requested changes Jan 18, 2018
View reviewed changes
index.js Outdated

function parserWrapper() {
var option;
var option = {};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Кажется можно убрать.

Copy link
Member Author

@Scrum Scrum Jan 18, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

это что бы assign не загнулся при мерже, так он получит undefined аля значение по умолчанию. был неправ )

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 8b9e4ed on milestone-0.3.2 into 29944dc on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 21d117d on milestone-0.3.2 into 29944dc on master.

@Scrum Scrum merged commit 4de93bb into master Jan 18, 2018
@Scrum Scrum deleted the milestone-0.3.2 branch January 18, 2018 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@voischev voischev voischev approved these changes

@michael-ciniawsky michael-ciniawsky Awaiting requested review from michael-ciniawsky

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Scrum @coveralls @voischev