fix(package): remove browser field
#16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the module or the render function is undefined after bundled with webpack or other bundlers, I think remove `browser` will be better for modularized frontend development. If you do not agree, just close the request. Sorry for my poor English.
hojas
requested review from
michael-ciniawsky,
mrmlnc and
voischev
as code owners
michael-ciniawsky
approved these changes
Mar 20, 2018
Member
michael-ciniawsky
left a comment
michael-ciniawsky
left a comment
There was a problem hiding this comment.
@hojas Thx
Maybe better to remove it completely in the near future🤔
Scrum
approved these changes
Mar 20, 2018
Member
|
@hojas 🤝 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the module or the render function is undefined after bundled with webpack or other bundlers, I think remove
browserwill be better for modularized frontend development. If you do not agree, just close the request. Sorry for my poor English.