Skip to content

Conversation

@lucioerlan
Copy link
Contributor

🔨🔨 adding Performance: the refactored code might perform a little better than the original code

  • Clarity: The refactored code is clearer and easier to read, since the type logic is encapsulated in separate objects.
  • Reusability: The refactored code allows reusing the type checker functions in other parts of the code.
  • Simplicity: The refactored code is simpler, as type checks are performed in separate functions, making the main code shorter and more concise.
  • Maintainability: The refactored code is easier to maintain, as future modifications to the type checks can be made in the separate functions, without affecting the main code.
  • Performance: The refactored code may have slightly better performance than the original code, as the type checker functions are executed only once, instead of repeating the check logic for each option.

adding Performance: the refactored code might perform a little better than the original code
@dhwaneetbhatt
Copy link
Contributor

Tests are failing because it cannot fetch a package in ubuntu when running CI. Will try again tomorrow. If it does not get sorted, will investigate.

@dhwaneetbhatt
Copy link
Contributor

@lucioerlan could you please update your fork with upstream changes from develop? We have fixed the pipeline. It would allow us to run tests on your changes and move ahead for review.

@dhwaneetbhatt dhwaneetbhatt merged commit e56e0ea into postmanlabs:develop Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants