Deprecated rawTableNames
#315
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
rawTableNamesfield inSQLWatchOptionshas been deprecated. Now, all tables specified in the tables option will be watched, including PowerSync tables with prefixes.As part of this update, I reviewed how the Dart SDK handles the
triggerOnTablesinput here. In the Dart SDK, the tables specified are expanded intotableName,ps_data__tableName, andps_data_local__tableName.However, because of how
onChangeandwatchare currently used (watchinvokesonChange), table expansion cannot occur inwatch. Therefore, table expansion now happens inonChangeand tables are always mapped fromps_data_tableName/ps_data_local__tableNametotableName.One issue with the
rawTableNames: trueoption was that specifying a view name (such aslists) wouldn’t triggeronChangeorwatch. This issue has now been resolved as part of these changes.Basic test
Now with unit tests 😇