feat: operation_id for trigger based diffs #770
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The trigger based diff logic currently implements a temporary SQLite table of the form
CREATE TEMP TABLE destination ( id TEXT, -- The modified row's id operation TEXT, timestamp TEXT, value TEXT, previous_value TEXT );We create and store operations on the configured
INSERT,UPDATEandDELETEevents.These operations are currently ordered by the timestamp of the operation which is stored as an ISO string with millisecond resolution. The millisecond resolution is not ideal for this. Certain operations could be executed in a shorter timeframe than the resolution - which can break the ordering of ops!
This PR adds an auto incrementing
operation_idcolumn to the tracked table. This ensures operations can be robustly queried in the exact order in which they were executed.