Skip to content

MySQL: Removed duplicate snapshot query stream invocation #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 9, 2025
Merged

MySQL: Removed duplicate snapshot query stream invocation #175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cadb128
MySQL: Removed duplicate snapshot query stream invocation
Rentacookie Jan 9, 2025
c5705f4
Added changeset
Rentacookie Jan 9, 2025
1bf04de
Revert transaction commit and rollback
Rentacookie Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/perfect-plums-cry.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@powersync/service-module-mysql': patch
---

Resolved excessive memory consumption during MySQL initial replication.
8 changes: 6 additions & 2 deletions modules/module-mysql/src/replication/BinLogStream.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,12 +305,16 @@ AND table_type = 'BASE TABLE';`,
columns = toColumnDescriptors(fields);
});

for await (let row of query.stream()) {
for await (let row of stream) {
if (this.stopped) {
throw new Error('Abort signal received - initial replication interrupted.');
}

if (columns == null) {
throw new Error(`No 'fields' event emitted`);
}
const record = common.toSQLiteRow(row, columns!);

const record = common.toSQLiteRow(row, columns!);
await batch.save({
tag: storage.SaveOperationTag.INSERT,
sourceTable: table,
Expand Down
Loading