Skip to content

Conversation

@rkistner
Copy link
Contributor

@rkistner rkistner commented Jul 1, 2024

Fixes:

The core issue was in the if (beforeId != afterId) { comparison. Since the ids are bson.UUID objects, they could be different objects despite having the same value.

@rkistner rkistner requested a review from stevensJourney July 1, 2024 11:24
@changeset-bot
Copy link

changeset-bot bot commented Jul 1, 2024

🦋 Changeset detected

Latest commit: 0c1ec44

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@powersync/service-core Patch
powersync-open-service Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@rkistner rkistner marked this pull request as ready for review July 1, 2024 11:34
@rkistner rkistner merged commit 8f8abce into main Jul 1, 2024
@rkistner rkistner deleted the fix-full-replication-id branch July 1, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants