Skip to content

Conversation

@simolus3
Copy link
Contributor

When a default sync stream uses a subscription parameter, that parameter will always be null. This makes auto_subscribe: true streams with parameters kind of useless.

Since this behavior is somewhat confusing (see this discord thread), it's better to warn about it. So this, tracks the use of subscription parameters in compiled clauses and then warns if they're used in a default stream.

@simolus3 simolus3 requested a review from rkistner October 17, 2025 13:59
@changeset-bot
Copy link

changeset-bot bot commented Oct 17, 2025

🦋 Changeset detected

Latest commit: 33771e6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 17 packages
Name Type
@powersync/service-sync-rules Patch
@powersync/service-jpgwire Patch
@powersync/service-core-tests Patch
@powersync/service-core Patch
@powersync/lib-services-framework Patch
@powersync/service-module-mongodb-storage Patch
@powersync/service-module-mongodb Patch
@powersync/service-module-mysql Patch
@powersync/service-module-postgres-storage Patch
@powersync/service-module-postgres Patch
@powersync/lib-service-postgres Patch
@powersync/service-module-core Patch
@powersync/service-image Patch
test-client Patch
@powersync/service-rsocket-router Patch
@powersync/lib-service-mongodb Patch
@powersync/service-schema Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

rkistner
rkistner previously approved these changes Oct 20, 2025
Base automatically changed from clause-visitor to main October 21, 2025 07:07
@simolus3 simolus3 dismissed rkistner’s stale review October 21, 2025 07:07

The base branch was changed.

@simolus3 simolus3 force-pushed the sync-streams-default-parameter-warning branch from f09370b to 33771e6 Compare October 21, 2025 07:07
@simolus3 simolus3 marked this pull request as ready for review October 21, 2025 07:07
@simolus3 simolus3 requested a review from rkistner October 21, 2025 07:07
@simolus3 simolus3 merged commit 0268858 into main Oct 21, 2025
21 checks passed
@simolus3 simolus3 deleted the sync-streams-default-parameter-warning branch October 21, 2025 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants