-
Notifications
You must be signed in to change notification settings - Fork 28
Fix memory leaks when retrying replication #395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c3d8ca3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
stevensJourney
approved these changes
Nov 11, 2025
Collaborator
stevensJourney
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This primarily fixes memory leaks occurring when restarting application. The same issue affected the replication jobs for Postgres, MongoDB and MySQL.
The basic issue is that every time a new replication job was started, a new PgManager/MongoManager/MySQLConnectionManager was created and persisted on the ConnectionManagerFactory, which was never released. If there is a persistent connection error, a new job is started every couple of seconds, increasing memory usage indefinitely. In some cases, this could lead to a 200MB+ memory increase per hour.
The main fix is to keep track of when these connection managers are closed, and then clean up these instances.
Additional fixes:
replicateLoop. This moves the retry logic to now be purely managed by the top-level replicator, instead of having multiple levels of retries for different types of errors. This also removes some double-logging of replication errors (e.g. "Replication failed" and "Replication error" for the same error). This also means that if there are multiple replication processes running, it is now feasible for another process to take over if one runs into errors.Sync rules: <x> have been locked by another process for replicationmessages, include the expiration time of the lock - this helps to identify whether the lock is actually active or not.Tested by using an invalid connection string, manually disabling the ErrorRateLimiter delays (variable), manually disabling the AbstractReplicator delay (5s), then measuring memory usage over time with Chrome's inspector.