[Postgres] Fix custom type parsing for initial snapshot queries #403
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for parsing custom Postgres types into JSON was added in #339 (1.15.3). However, there was an issue that caused it to only decode the types correctly for streaming replication - initial replication still used the raw
(1, 2)-type values.This did not affect the timestamp format options also added around the same time, only custom types, enums, etc.
This fixes the issue, and adds a test. We use the type info returned with the results of the snapshot query - no need to fetch types from the underlying table.
This also cleans up code to remove a CustomTypeRegistry parameter passed through a couple of layers - it was never used.