Skip to content

supabase-todolist Demo App - SupabaseConnector does not need a db instance #165

@JavascriptMick

Description

@JavascriptMick

Pretty sure there is an unnecessary and, frankly confusing mistake in the supabase-todolist demo code.

e.g. this file....
https://github.com/powersync-ja/powersync.dart/blob/main/demos/supabase-todolist/lib/powersync.dart

From Line 28

class SupabaseConnector extends PowerSyncBackendConnector {
  PowerSyncDatabase db;

  Future<void>? _refreshFuture;

  SupabaseConnector(this.db);

the db instance is not used inside the class or by users of the class. Smells like a refactor happened and this was left in. I was able to rip the property out and run the demo app just fine...

class SupabaseConnector extends PowerSyncBackendConnector {
  Future<void>? _refreshFuture;

  SupabaseConnector();

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions