[Feature] Changesets #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manrich121
reviewed
Oct 19, 2023
.github/workflows/dev-packages.yaml
Outdated
| @@ -0,0 +1,36 @@ | |||
| # Action to publish packages under the `next` tag for testing | |||
| # Packages are versioned as `0.0.0-dev.{short-sha}` | |||
There was a problem hiding this comment.
Is this comment still accurate? Changesets version pattern is slightly different
Collaborator
Author
There was a problem hiding this comment.
Good catch! This has been updated to the new format
Manrich121
reviewed
Oct 19, 2023
package.json
Outdated
| ] | ||
| }, | ||
| "dependencies": { | ||
| "@changesets/cli": "^2.26.2" |
There was a problem hiding this comment.
This can be moved to devDependencies seeing that it is only used on local dev and CI and not when the package is installed somewhere else
Collaborator
Author
There was a problem hiding this comment.
Moved this now 🙏
Manrich121
previously approved these changes
Oct 19, 2023
Manrich121
left a comment
Manrich121
left a comment
There was a problem hiding this comment.
Minor comments, but happy with the changes
Manrich121
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the Changesets tooling for this repo's package management.