-
Notifications
You must be signed in to change notification settings - Fork 10
Support for Arm Cortex-M7 (NUCLEO-F767ZI) #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Thing-han, Lim <15379156+potsrevennil@users.noreply.github.com>
Signed-off-by: Thing-han, Lim <15379156+potsrevennil@users.noreply.github.com>
Signed-off-by: Thing-han, Lim <15379156+potsrevennil@users.noreply.github.com>
Signed-off-by: Thing-han, Lim <15379156+potsrevennil@users.noreply.github.com>
Signed-off-by: Thing-han, Lim <15379156+potsrevennil@users.noreply.github.com>
Signed-off-by: Thing-han, Lim <15379156+potsrevennil@users.noreply.github.com>
Signed-off-by: Thing-han, Lim <15379156+potsrevennil@users.noreply.github.com>
mkannwischer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @potsrevennil.
Here are some initial comments.
I think the benchmarks need to be reworked a bit because this core actually comes with an instruction cache. We'll likely have to do some cache warming and potentially also have to take the median/average over multiple runs.
|
Please add emulated tests using the mps2-an500. |
Signed-off-by: Thing-han, Lim <15379156+potsrevennil@users.noreply.github.com>
Signed-off-by: Thing-han, Lim <15379156+potsrevennil@users.noreply.github.com>
Signed-off-by: Thing-han, Lim <15379156+potsrevennil@users.noreply.github.com>
mkannwischer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Matthias J. Kannwischer <matthias@kannwischer.eu>
Signed-off-by: Thing-han, Lim <15379156+potsrevennil@users.noreply.github.com>
* limit the scope of `with` in nix Signed-off-by: Thing-han, Lim <15379156+potsrevennil@users.noreply.github.com> * fix multi targets of libopencm3 string concatanation in nix Signed-off-by: Thing-han, Lim <15379156+potsrevennil@users.noreply.github.com> * support for cortex-m7 Signed-off-by: Thing-han, Lim <15379156+potsrevennil@users.noreply.github.com> * update build ci for m7 Signed-off-by: Thing-han, Lim <15379156+potsrevennil@users.noreply.github.com> * refactor tests script interface by removing the emulate flag Signed-off-by: Thing-han, Lim <15379156+potsrevennil@users.noreply.github.com> * support for cortex-m7 in the tests script Signed-off-by: Thing-han, Lim <15379156+potsrevennil@users.noreply.github.com> * remove boards that are not supported Signed-off-by: Thing-han, Lim <15379156+potsrevennil@users.noreply.github.com> * rename stm32f767zi -> nucleo-f767zi Signed-off-by: Thing-han, Lim <15379156+potsrevennil@users.noreply.github.com> * output flash output if verbose flag is on Signed-off-by: Thing-han, Lim <15379156+potsrevennil@users.noreply.github.com> * merge shared_options and shared_args for tests script cli Signed-off-by: Thing-han, Lim <15379156+potsrevennil@users.noreply.github.com> * nucleo-f767zi: do not use CCM Signed-off-by: Matthias J. Kannwischer <matthias@kannwischer.eu> * take median value for speed benchmark Signed-off-by: Thing-han, Lim <15379156+potsrevennil@users.noreply.github.com> --------- Signed-off-by: Thing-han, Lim <15379156+potsrevennil@users.noreply.github.com> Signed-off-by: Matthias J. Kannwischer <matthias@kannwischer.eu> Co-authored-by: Matthias J. Kannwischer <matthias@kannwischer.eu> Signed-off-by: Thing-han, Lim <15379156+potsrevennil@users.noreply.github.com>
In order to support multi-platform including QEMU, simplify the usage of the
testsscript and avoid some confusion,as @mkannwischer suggested, the
-eflag is removed, only the platform is required.Thus the
testsinterface is changed as follow:within nix